Fix autocomplete script errors in zsh #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
Coverage 89.37% 89.37%
Complexity 255 255
=========================================
Files 4 4
Lines 3482 3482
Branches 831 831
=========================================
Hits 3112 3112
Misses 178 178
Partials 192 192
Continue to review full report at Codecov.
|
remkop
added a commit
that referenced
this pull request
Jul 31, 2018
…ixes. Thanks [Anthony Keenan](https://github.com/anthonykeenan)!
|
Merged and added credits in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been testing the autocomplete script in
zsh, and I came accross a few errors.shoptisn't available inzshcompoptdoesn't seem to be understood inzsheven when usingbashcompinit,completewith the same options works, I've added an alias when usingzshforcompopt->completesetopt COMPLETE_ALIASESwhen using zsh or the alias doesn't work properly when autocompletingI've attempted to fix them by adding a check for the shell the script is being run under. I've tested the changes using Ubuntu Server 18.04 LTS and zsh 5.4.2, and Mac OS and zsh 5.5.1.