Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill array values before setting them as value #523

Merged

Conversation

knutwalker
Copy link
Contributor

When using setter methods for array options, the values aren't set when the setter is invoked, making it impossible to do any kind of processing on the values other than storing the array, as every value is null.

@codecov-io
Copy link

codecov-io commented Oct 21, 2018

Codecov Report

Merging #523 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #523   +/-   ##
=========================================
  Coverage     89.01%   89.01%           
  Complexity      284      284           
=========================================
  Files             4        4           
  Lines          3906     3906           
  Branches        959      959           
=========================================
  Hits           3477     3477           
  Misses          214      214           
  Partials        215      215
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 89.03% <100%> (ø) 159 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac5cac...e2be586. Read the comment docs.

@remkop remkop added this to the 3.8 milestone Oct 21, 2018
@remkop
Copy link
Owner

remkop commented Oct 21, 2018

Thanks for the PR!
This, as well as the other PRs, look like good changes.
I tried to do “Rebase and merge” from the GitHub web UI, but there seems to be a conflict.
Would you mind rebasing them?

@knutwalker knutwalker force-pushed the fill-arrays-before-setting-as-value branch from e2be586 to fe6dbce Compare October 22, 2018 08:38
@knutwalker
Copy link
Contributor Author

Sure, I've rebased the PRs

@remkop remkop merged commit 278be3b into remkop:master Oct 22, 2018
@knutwalker
Copy link
Contributor Author

Sure, I've rebased the PRs

1 similar comment
@knutwalker
Copy link
Contributor Author

Sure, I've rebased the PRs

remkop added a commit that referenced this pull request Oct 22, 2018
@remkop remkop modified the milestones: 4.1, 3.8 Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants