Add a way to get the argument attempted to be overwritten from an OverwrittenOptionException #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a nice way to get the ArgSpec of the option which was being overwritten before throwing an OverwrittenOptionException. The ArgSpec is retrieved through OverwrittenOptionException#getOverwritten(), which can be taken advantage of in a custom IExceptionHandler2 to automate exception handling, generate custom error messages, etc.
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
============================================
+ Coverage 89.14% 89.15% +<.01%
Complexity 285 285
============================================
Files 4 4
Lines 3933 3936 +3
Branches 964 964
============================================
+ Hits 3506 3509 +3
Misses 213 213
Partials 214 214
Continue to review full report at Codecov.
|
|
Thanks for the pull request! |
remkop
added a commit
that referenced
this pull request
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a nice way to get the
ArgSpecof the option which was being overwritten before throwing anOverwrittenOptionException. TheArgSpecis retrieved throughOverwrittenOptionException#getOverwritten(), which can be taken advantage of in a customIExceptionHandler2to automate exception handling, generate custom error messages, etc.I was in the process of writing a custom
IExceptionHandler2and noticed someParameterExceptions have convenience methods for accessing the root of the exception (seeMissingParameterException#getMissing()) and thoughtOverwrittenOptionExceptionwas missing such a method. It's a tiny pr, but seems useful to me at least. Thanks for the consideration.