-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add picocli-shell-JLine3 module #574
Conversation
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
===========================================
+ Coverage 94.63% 94.7% +0.07%
Complexity 315 315
===========================================
Files 4 4
Lines 4045 4045
Branches 990 990
===========================================
+ Hits 3828 3831 +3
+ Misses 75 73 -2
+ Partials 142 141 -1
Continue to review full report at Codecov.
|
@mattirn Awesome, thank you very much! Question: would it make sense to put this in a separate module: |
@remkop thank you for the awesome work! I have created a separate module.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was quick! I have a few nitpicks about the documentation (there’s some mentions of JLine 2 that we should change to 3) but otherwise this is exactly what I had in mind. Thank you very much!
Merged and updated release notes. |
I’m releasing 3.9, but I’m having some trouble publishing the |
The |
No description provided.