Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing String concatenation, now StringBuilder is being used #591

Merged

Conversation

sergioescala
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #591 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #591   +/-   ##
=========================================
  Coverage     98.09%   98.09%           
  Complexity      350      350           
=========================================
  Files             4        4           
  Lines          4096     4096           
  Branches       1005     1005           
=========================================
  Hits           4018     4018           
  Misses           23       23           
  Partials         55       55
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/AutoComplete.java 96.68% <100%> (ø) 106 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e86817...262e0a4. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Jan 5, 2019

Looks good. I’ve started the release for picocli-3.9.0; I’ll merge this when the release is done. Thanks for the PR!

@remkop remkop merged commit d735be5 into remkop:master Jan 5, 2019
@remkop
Copy link
Owner

remkop commented Jan 5, 2019

Merged.
I’ll update the release notes (for the next release) later.
Thanks for the pull request!

@remkop remkop added this to the 4.0 milestone Jan 5, 2019
@sergioescala
Copy link
Contributor Author

Thanks to you @remkop for merging my changes!

remkop added a commit that referenced this pull request Jan 7, 2019
@remkop remkop modified the milestones: 4.0, 3.9.1 Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants