Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended example of picocli-shell-jline2 with IParameterConsumer #775

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

querqueq
Copy link
Contributor

I also tested interactive options in the jline3 variant. They work fine.

Changes for #767

@codecov-io
Copy link

codecov-io commented Jul 28, 2019

Codecov Report

Merging #775 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #775   +/-   ##
=========================================
  Coverage     93.15%   93.15%           
  Complexity      385      385           
=========================================
  Files             2        2           
  Lines          5684     5684           
  Branches       1480     1480           
=========================================
  Hits           5295     5295           
  Misses          186      186           
  Partials        203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe37466...1f886d5. Read the comment docs.

@remkop remkop merged commit 182a31f into remkop:master Jul 29, 2019
@remkop remkop added this to the 4.0.1 milestone Jul 29, 2019
@remkop remkop added type: doc 📘 theme: shell An issue or change related to interactive (JLine) applications labels Jul 29, 2019
remkop added a commit that referenced this pull request Jul 29, 2019
…th picocli's `interactive` options for passwords.
remkop added a commit that referenced this pull request Jul 29, 2019
…using `PicocliSpringFactory`; jline2 incompatibility with picocli's `interactive` password options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: shell An issue or change related to interactive (JLine) applications type: doc 📘
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants