Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit Parameter Consumers when doing GraalVM reflection generation #804

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

byteit101
Copy link

Fix #803 by visiting the IParameterConsumers

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #804 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #804   +/-   ##
=========================================
  Coverage     93.23%   93.23%           
  Complexity      385      385           
=========================================
  Files             2        2           
  Lines          5702     5702           
  Branches       1483     1483           
=========================================
  Hits           5316     5316           
  Misses          185      185           
  Partials        201      201

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d493b9e...9e3698e. Read the comment docs.

@remkop remkop added type: bug 🐛 theme: codegen An issue or change related to the picocli-codegen module labels Sep 5, 2019
@remkop remkop added this to the 4.0.4 milestone Sep 5, 2019
@remkop remkop merged commit f787c74 into remkop:master Sep 5, 2019
@remkop
Copy link
Owner

remkop commented Sep 5, 2019

Merged! Thank you for the contribution!

remkop added a commit that referenced this pull request Sep 8, 2019
…ustom `IParameterConsumer` caused native-image to fail. Added tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: codegen An issue or change related to the picocli-codegen module type: bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom IParameterConsumer causes native-image to fail
4 participants