Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc issues #874

Merged
merged 2 commits into from
Nov 24, 2019
Merged

Javadoc issues #874

merged 2 commits into from
Nov 24, 2019

Conversation

deining
Copy link
Contributor

@deining deining commented Nov 23, 2019

Hi,

while reading the API docs of the newly introduced PropertiesDefaultProvider, I realized that parts of the javadoc were missing. The attached patch fixes this issue.
A second patch fixes all javadoc errors that were present in the project.

Thanks for considering my input.

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #874   +/-   ##
=========================================
  Coverage     92.83%   92.83%           
  Complexity      388      388           
=========================================
  Files             2        2           
  Lines          5810     5810           
  Branches       1512     1512           
=========================================
  Hits           5394     5394           
  Misses          205      205           
  Partials        211      211
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 92.5% <ø> (ø) 273 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cf983...e7fe07e. Read the comment docs.

@remkop remkop merged commit 5931c2b into remkop:master Nov 24, 2019
@remkop remkop added this to the 4.2 milestone Nov 24, 2019
@remkop
Copy link
Owner

remkop commented Nov 24, 2019

Merged into master.
Thank you!

@remkop remkop modified the milestones: 4.2, 4.1.1 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants