-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump JLine to 3.13.2 #888
Bump JLine to 3.13.2 #888
Conversation
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
=========================================
Coverage 92.84% 92.84%
Complexity 388 388
=========================================
Files 2 2
Lines 5812 5812
Branches 1512 1512
=========================================
Hits 5396 5396
Misses 205 205
Partials 211 211 Continue to review full report at Codecov.
|
@mattirn I like the asciinema a lot! This looks like a very nice PR, thank you! Can I ask you to also update the README for the Again, thank you! This looks really nice! |
@mattirn I saw you pushed updates to the documentation, thank you! I am happy to merge it as is, but I really liked the asciinema you created and I wondered if we could include those in the readme - if you are okay with that, that is... What do you think? |
I have already included the asciinema linked in this pull request in README. You are free to include also others if you like JLine demos :). |
Merged into master. |
Command parameter completion is still missing...
@remkop, if you can add some command parameters to example I can try to implement completers.
PS.
top
command is working ok... what you see is asciinema problem ;)