Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ${project.groupId} instead of deprecated ${groupId} #975

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

dmitry-timofeev
Copy link
Contributor

${groupId} and ${artifactId} are deprecated and cause the following warning during the build:

[WARNING] The expression ${groupId} is deprecated. Please use ${project.groupId} instead.
[WARNING] The expression ${artifactId} is deprecated. Please use ${project.artifactId} instead.

${groupId} and ${artifactId} are deprecated and cause the following warning:

[WARNING] The expression ${groupId} is deprecated. Please use ${project.groupId} instead.
[WARNING] The expression ${artifactId} is deprecated. Please use ${project.artifactId} instead.
@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #975 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #975   +/-   ##
=========================================
  Coverage     94.71%   94.71%           
  Complexity      414      414           
=========================================
  Files             2        2           
  Lines          6093     6093           
  Branches       1613     1613           
=========================================
  Hits           5771     5771           
  Misses           90       90           
  Partials        232      232           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf888c5...ea3b0bf. Read the comment docs.

@remkop remkop added this to the 4.3 milestone Mar 11, 2020
@remkop remkop merged commit ffab339 into remkop:master Mar 11, 2020
remkop added a commit that referenced this pull request Mar 11, 2020
…ect.groupId}` instead of deprecated `${groupId}`
@remkop
Copy link
Owner

remkop commented Mar 11, 2020

Your changes are now live.
Thank you for the contribution!

@dmitry-timofeev dmitry-timofeev deleted the patch-1 branch March 12, 2020 12:03
@dmitry-timofeev
Copy link
Contributor Author

Wonderful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants