Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trim whitespace from GitHub usernames during validation #213

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: trim whitespace from GitHub usernames during validation #213

merged 1 commit into from
Dec 19, 2024

Conversation

SheyiB
Copy link
Contributor

@SheyiB SheyiB commented Dec 19, 2024

Changes

  • Added whitespace sanitization for GitHub usernames
  • Applied cleaning to both API requests and redirect URLs
  • Ensures consistent username handling throughout the authentication flow

Implementation

Introduced a removeWhitespace utility function that strips all whitespace from the username string before processing:

Related Issue

Fixes #212

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unwrapped-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 10:53am

@JonnyBurger
Copy link
Member

Thanks!

@JonnyBurger JonnyBurger merged commit 65f718f into remotion-dev:main Dec 19, 2024
2 checks passed
@SheyiB
Copy link
Contributor Author

SheyiB commented Dec 19, 2024

Thanks!

A pleasure🤭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub username validation fails with leading/trailing whitespace
2 participants
@SheyiB @JonnyBurger