Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent hyperlink for sharing added "_blank" fron new tab also added right arrow icons after unwrap #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"polished": "^4.2.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-icons": "^5.4.0",
"react-spring": "^9.7.3",
"remotion": "4.0.240",
"serve-static": "^1.15.0",
Expand Down
5 changes: 4 additions & 1 deletion remotion/PromoVideo/PromoVideoCTA.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { TransitionSeries, springTiming } from "@remotion/transitions";
import { flip } from "@remotion/transitions/flip";
import React from "react";
import { FaArrowRight } from "react-icons/fa";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a whole icon set?
this adds quite a lot of bundle size

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

import {
AbsoluteFill,
interpolate,
Expand Down Expand Up @@ -95,12 +96,14 @@ export const PromoVideoCallToAction: React.FC<{
justifyContent: "center",
alignItems: "center",
color: "white",
gap: 10,
fontSize: 40,
fontWeight: "bold",
scale: String(1 - pressIn * 0.1),
}}
>
Unwrap
<FaArrowRight size={15} color="white" />
<p>Unwrap</p>
</div>
</AbsoluteFill>
</TransitionSeries.Sequence>
Expand Down
9 changes: 8 additions & 1 deletion vite/SignInWithGitHub.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
import { useState } from "react";
import buttonStyles from "./Button/styles.module.css";
import { signInWithGitHubLink } from "./sign-in-with-github";

export const SignInWithGitHub: React.FC = () => {
const [isHovered, setIsHovered] = useState(false);
return (
<a
style={{ textDecoration: "none" }}
style={{
textDecoration: isHovered ? "underline" : "none",
transition: "text-decoration 0.3s ease",
}}
onMouseEnter={() => setIsHovered(true)}
onMouseLeave={() => setIsHovered(false)}
className={buttonStyles.loginwithgithub}
href={signInWithGitHubLink(true)}
>
Expand Down
4 changes: 2 additions & 2 deletions vite/VideoPage/Actions/FurtherActions.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Link } from "@tanstack/react-router";
import { FaUserCircle } from "react-icons/fa";
import { PrivateContributionsIcon } from "../../../icons/PrivateContributionsIcon";
import { UserIcon } from "../../../icons/UserIcon";
import { signInWithGitHubLink } from "../../sign-in-with-github";
import { FurtherAction } from "./FurtherAction";
import styles from "./styles.module.css";
Expand All @@ -15,7 +15,7 @@ export const FurtherActions: React.FC = () => {
<div className={styles.furtherActionsButtonContainer}>
<Link to="/">
<FurtherAction
icon={(params) => <UserIcon {...params} width={15} />}
icon={(params) => <FaUserCircle {...params} width={15} />}
label="Unwrap another user"
/>
</Link>
Expand Down
2 changes: 2 additions & 0 deletions vite/VideoPage/Actions/SharingActions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export const SharingActions: React.FC<{}> = () => {
return (
<div className={styles.sharingActionsWrapper}>
<Link
target="_blank"
from={userRoute.id}
to={"share"}
params={() => {
Expand All @@ -31,6 +32,7 @@ export const SharingActions: React.FC<{}> = () => {
/>
</Link>
<Link
target="_blank"
from={videoRoute.id}
to={"share"}
params={{ username }}
Expand Down