Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stripping the SIG prefix for POSIX compliance #957

Closed
wants to merge 3 commits into from

Conversation

knight
Copy link

@knight knight commented Dec 29, 2016

changes which fix #956

@knight
Copy link
Author

knight commented Jan 3, 2017

@remy is this PR any good?

@remy
Copy link
Owner

remy commented Sep 4, 2017

Super late to this PR, but can you let me know why this would be needed? Is it causing breaking elsewhere? (genuine question).

@knight
Copy link
Author

knight commented Oct 2, 2017

On Linux auto re-spawning after detected changes does not work because sh does not recognize the SIGNAL constants with prefix. Please see my comments on the issue #956

@heisian
Copy link
Contributor

heisian commented Dec 6, 2017

@knight why not do it the way an answer in the link you referenced suggests?

#!/bin/sh

set -x
set +o posix
sleep 100 &
pid=$!
kill -s SIGSTOP "$pid"
sleep 2
kill -s SIGCONT "$pid"
set -o posix

@remy
Copy link
Owner

remy commented Dec 15, 2017

Fixed (alternative method) in nodemon@1.13.2

@remy remy closed this Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the SIG prefix is not valid according to the POSIX standard
3 participants