-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests with parameters but without @Unroll will have extraInfo all grouped to first iteration #244
Comments
Hi @renatoathaydes , I want to create a PR for this, but I don't have the permission to create a branch for this, could you help me with it? thanks |
Done.
|
Sorry @renatoathaydes , I still get 403 when push my changes to |
HI @renatoathaydes , sorry I did it in the wrong way, and I have fixed the problem. Could you help to review my PR when you have time? thanks |
…t-without-unroll-will-have-extrainfo-all-grouped-to-first-iteration Fix #244 all info are grouped into 1st itertaion when no Unroll
Hi @renatoathaydes, |
I've found a reliable way to know when a spec is rolledup/unrolled, which fixed the issue for good... I reverted the change to the main HTML report creator so that we do not prepend text to each "extra info" message. That was not needed. But there are a few more bugs I want to fix before the next release. Hoping to release within a few days. |
Hi @renatoathaydes , |
Hi @Frankie0701 . Yeah, I did not update the groovy3 branch because it takes some work to do it and I was not too keen on keeping that branch up-to-date... but I can do it if you want it, just need to cherrypick a few commits I guess. |
It was not hard to do it, so I released It may take a few hours for Maven Central to make the new version available. |
Hi @renatoathaydes , |
We notice after upgrade to 2.3.2-groovy-3.0, our tests without @unroll that has extarInfo for each iteration will have all extraInfo only displayed in first iteration, and leave rest iterations' extraInfo blank.
For example, with following test, you can see the spec template screenshot that extra info are displayed in first iteration including all info from the rest iterations. This works fine before our upgrade from 1.7.1
def 'test without unroll'() {
when:
reportInfo("extra info for iteration: " + input)
then:
true
where:
input << [1, 2]
}
The text was updated successfully, but these errors were encountered: