Save and re-use views from memory store #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,10 @@ module.exports = BaseView = Backbone.View.extend({ | |||
| options.collection_params = options.collection.params; | |||
| } | |||
|
|
|||
| if(options.preventPostInitialize){ | |||
There was a problem hiding this comment.
We wouldn't need preventPostInitialize anymore, right?
|
I like the approach, however I don't think it's appropriate to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When view are created via Handlebars view helper, they are added to a memory store like models and collections. Later when BaseView tries to re-attach views to DOM it looks up memory store for the same name view.
I am not sure if using fetcher to hold viewStore is a good idea as fetcher mainly deals with serializeable data. Any ideas where we could store views?