Laravel 9.x #33
Merged
Laravel 9.x #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html
|
✅ Shift did not find any models which unnecessarily set the |
|
✅ Shift did not find any unnecessary attributes listed in the |
|
✅ Shift did not find any |
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage 93.42% 93.42%
Complexity 22 22
=========================================
Files 3 3
Lines 76 76
=========================================
Hits 71 71
Misses 5 5 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes from your build using the "Shift Workbench".
Before merging, you need to:
shift-build-2349branchDon't hesitate to send your feedback to shift@laravelshift.com or share your ❤️ for Shift on Twitter.