Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KubeConfig temp certificate filename extension .pem #186

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

stefankonig
Copy link
Contributor

With the merging of #182 i think an unintentional bug was introduced in the temp certificate filename. The $fileName is included in the Str::slug function parameter, causing the certificate filename to lose the dot of the file extension.

before: ctx-minikube-ca-cert.pem
now: ctx-minikube-minikube-httpsminikube8443-ca-certpem
after fix: ctx-minikube-minikube-httpsminikube8443-ca-cert.pem

i have additionally added a few extra assertions to the test_kube_config_from_yaml_file_with_base64_encoded_ssl unittest to check the generated filename.

@stefankonig stefankonig force-pushed the fixTempCertFilenames branch 2 times, most recently from e8347f2 to f36577f Compare January 4, 2022 11:22
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #186 (236a771) into master (990acd6) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
+ Coverage     95.09%   95.22%   +0.12%     
  Complexity      694      694              
============================================
  Files            70       70              
  Lines          1693     1696       +3     
============================================
+ Hits           1610     1615       +5     
+ Misses           83       81       -2     
Impacted Files Coverage Δ
src/Traits/Cluster/LoadsFromKubeConfig.php 94.31% <100.00%> (ø)
src/Traits/Cluster/MakesWebsocketCalls.php 89.74% <0.00%> (+0.41%) ⬆️
src/Kinds/K8sPod.php 95.93% <0.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990acd6...236a771. Read the comment docs.

@rennokki rennokki merged commit 2bd53bb into renoki-co:master Jan 4, 2022
@rennokki
Copy link
Member

rennokki commented Jan 4, 2022

Thank you. <3 I usually rely on tests for these, it seems like this was missing. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants