Fix KubeConfig temp certificate filename extension .pem #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the merging of #182 i think an unintentional bug was introduced in the temp certificate filename. The
$fileName
is included in theStr::slug
function parameter, causing the certificate filename to lose the dot of the file extension.before:
ctx-minikube-ca-cert.pem
now:
ctx-minikube-minikube-httpsminikube8443-ca-certpem
after fix:
ctx-minikube-minikube-httpsminikube8443-ca-cert.pem
i have additionally added a few extra assertions to the
test_kube_config_from_yaml_file_with_base64_encoded_ssl
unittest to check the generated filename.