Skip to content

Commit

Permalink
feat(testing): convert CI testing to use Makefile actions (GoogleClou…
Browse files Browse the repository at this point in the history
…dPlatform#3579)

* chore: try manually updating one GHA workflow to use make

* trivial edit so ai-platform/snippets tests are not skipped.

* remove empty stanza

* pushing, to refresh workflows. adding workflow dispatch for another testing option.

* add env var for gcp project

* directory name typo

* update shared workflow to use Make

* update unique workflows, and the util template

these workflows do not use the shared test.yaml, and have slight
customizations.

Also cleans up some trailing whitespace found in these files.

* fix bracket spacing

* fix functions/slack directory

* add path match for shared test.yaml workflow

* add path match for reused workflow test.yaml

* add c8 as a dev dependency for packages that use it for testing

* fix: use the right project

* run toplevel npm install before installing sample deps

* Apply suggestions from code review

Co-authored-by: Patti Shin <pattishin@users.noreply.github.com>

---------

Co-authored-by: Patti Shin <pattishin@users.noreply.github.com>
  • Loading branch information
muncus and pattishin committed Jan 24, 2024
1 parent 4e90a2b commit c7ae7d6
Show file tree
Hide file tree
Showing 114 changed files with 351 additions and 69 deletions.
19 changes: 6 additions & 13 deletions .github/workflows/ai-platform-snippets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ jobs:
permissions:
contents: 'read'
id-token: 'write'
defaults:
run:
working-directory: 'ai-platform/snippets'
steps:
- uses: actions/checkout@v4.1.0
with:
Expand All @@ -64,30 +61,26 @@ jobs:
- name: Get npm cache directory
id: npm-cache-dir
shell: bash
run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
- uses: actions/cache@v3
id: npm-cache
with:
path: ${{ steps.npm-cache-dir.outputs.dir }}
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- name: install repo dependencies
run: npm install
working-directory: .
- name: install directory dependencies
run: npm install
- run: npm run build --if-present
- name: set env vars for scheduled run
if: github.event.action == 'schedule'
run: |
echo "MOCHA_REPORTER_SUITENAME=ai-platform-snippets" >> $GITHUB_ENV
echo "MOCHA_REPORTER_OUTPUT=${{github.run_id}}_sponge_log.xml" >> $GITHUB_ENV
echo "MOCHA_REPORTER=xunit" >> $GITHUB_ENV
- run: npm test
- name: Run Tests
run: make test dir=ai-platform/snippets
env:
GOOGLE_SAMPLES_PROJECT: "long-door-651"
LOCATION: ${{ steps.secrets.outputs.location }}
CAIP_PROJECT_ID: ${{ steps.secrets.outputs.caip_id }}
CAIP_PROJECT_ID: ${{ steps.secrets.outputs.caip_id }}
- name: upload test results for FlakyBot workflow
if: github.event.action == 'schedule' && always()
uses: actions/upload-artifact@v3
Expand All @@ -96,7 +89,7 @@ jobs:
with:
name: test-results
path: ai-platform/snippets/${{ env.MOCHA_REPORTER_OUTPUT }}
retention-days: 1
retention-days: 1
flakybot:
permissions:
contents: 'read'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-analytics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/analytics/**'
- '.github/workflows/appengine-analytics.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/analytics/**'
- '.github/workflows/appengine-analytics.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/analytics/**'
- '.github/workflows/appengine-analytics.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-building-an-app-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/building-an-app/build/**'
- '.github/workflows/appengine-building-an-app-build.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/building-an-app/build/**'
- '.github/workflows/appengine-building-an-app-build.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/building-an-app/build/**'
- '.github/workflows/appengine-building-an-app-build.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-building-an-app-update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/building-an-app/update/**'
- '.github/workflows/appengine-building-an-app-update.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/building-an-app/update/**'
- '.github/workflows/appengine-building-an-app-update.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/building-an-app/update/**'
- '.github/workflows/appengine-building-an-app-update.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-datastore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/datastore/**'
- '.github/workflows/appengine-datastore.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/datastore/**'
- '.github/workflows/appengine-datastore.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/datastore/**'
- '.github/workflows/appengine-datastore.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-endpoints.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/endpoints/**'
- '.github/workflows/appengine-endpoints.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/endpoints/**'
- '.github/workflows/appengine-endpoints.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/endpoints/**'
- '.github/workflows/appengine-endpoints.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-hello-world-flexible.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/hello-world/flexible/**'
- '.github/workflows/appengine-hello-world-flexible.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/hello-world/flexible/**'
- '.github/workflows/appengine-hello-world-flexible.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/hello-world/flexible/**'
- '.github/workflows/appengine-hello-world-flexible.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-hello-world-standard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/hello-world/standard/**'
- '.github/workflows/appengine-hello-world-standard.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/hello-world/standard/**'
- '.github/workflows/appengine-hello-world-standard.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/hello-world/standard/**'
- '.github/workflows/appengine-hello-world-standard.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-memcached.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/memcached/**'
- '.github/workflows/appengine-memcached.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/memcached/**'
- '.github/workflows/appengine-memcached.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/memcached/**'
- '.github/workflows/appengine-memcached.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-metadata-flexible.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/metadata/flexible/**'
- '.github/workflows/appengine-metadata-flexible.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/metadata/flexible/**'
- '.github/workflows/appengine-metadata-flexible.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/metadata/flexible/**'
- '.github/workflows/appengine-metadata-flexible.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-metadata-standard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/metadata/standard/**'
- '.github/workflows/appengine-metadata-standard.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/metadata/standard/**'
- '.github/workflows/appengine-metadata-standard.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/metadata/standard/**'
- '.github/workflows/appengine-metadata-standard.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-pubsub.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/pubsub/**'
- '.github/workflows/appengine-pubsub.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/pubsub/**'
- '.github/workflows/appengine-pubsub.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/pubsub/**'
- '.github/workflows/appengine-pubsub.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-static-files.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/static-files/**'
- '.github/workflows/appengine-static-files.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/static-files/**'
- '.github/workflows/appengine-static-files.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/static-files/**'
- '.github/workflows/appengine-static-files.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-storage-flexible.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/storage/flexible/**'
- '.github/workflows/appengine-storage-flexible.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/storage/flexible/**'
- '.github/workflows/appengine-storage-flexible.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/storage/flexible/**'
- '.github/workflows/appengine-storage-flexible.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-storage-standard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/storage/standard/**'
- '.github/workflows/appengine-storage-standard.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/storage/standard/**'
- '.github/workflows/appengine-storage-standard.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/storage/standard/**'
- '.github/workflows/appengine-storage-standard.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-twilio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/twilio/**'
- '.github/workflows/appengine-twilio.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/twilio/**'
- '.github/workflows/appengine-twilio.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/twilio/**'
- '.github/workflows/appengine-twilio.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-typescript.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/typescript/**'
- '.github/workflows/appengine-typescript.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/typescript/**'
- '.github/workflows/appengine-typescript.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/typescript/**'
- '.github/workflows/appengine-typescript.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/appengine-websockets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'appengine/websockets/**'
- '.github/workflows/appengine-websockets.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'appengine/websockets/**'
- '.github/workflows/appengine-websockets.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'appengine/websockets/**'
- '.github/workflows/appengine-websockets.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/asset-snippets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ on:
paths:
- 'asset/snippets/**'
- '.github/workflows/asset-snippets.yaml'
- '.github/workflows/test.yaml'
pull_request:
paths:
- 'asset/snippets/**'
- '.github/workflows/asset-snippets.yaml'
- '.github/workflows/test.yaml'
pull_request_target:
types: [labeled]
paths:
- 'asset/snippets/**'
- '.github/workflows/asset-snippets.yaml'
- '.github/workflows/test.yaml'
schedule:
- cron: '0 0 * * 0'
jobs:
Expand Down
Loading

0 comments on commit c7ae7d6

Please sign in to comment.