Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong parameter type #144

Merged
merged 4 commits into from
Jan 13, 2022
Merged

fix: wrong parameter type #144

merged 4 commits into from
Jan 13, 2022

Conversation

RahulGautamSingh
Copy link
Contributor

@RahulGautamSingh RahulGautamSingh commented Jan 13, 2022 •
edited by viceice
Loading

Changes:

  • Update type of options parameter in thee function maxSatisfying and minSatisfying.

Context:

@RahulGautamSingh RahulGautamSingh changed the title update type refactor: update parameter type Jan 13, 2022
viceice
viceice reviewed Jan 13, 2022
View reviewed changes
lib/specifier.d.ts Outdated Show resolved Hide resolved
lib/specifier.d.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits January 13, 2022 20:20
@viceice
Update lib/specifier.d.ts
32601d8 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice
Update lib/specifier.d.ts
1daddb6 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
viceice reviewed Jan 13, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot, that they are optional

lib/specifier.d.ts Outdated Show resolved Hide resolved
lib/specifier.d.ts Outdated Show resolved Hide resolved
lib/specifier.d.ts Outdated Show resolved Hide resolved
lib/specifier.d.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title refactor: update parameter type fix: wrong parameter type Jan 13, 2022
@viceice viceice merged commit 125d0a5 into renovatebot:main Jan 13, 2022
@RahulGautamSingh RahulGautamSingh deleted the refactor/modify-parameter-type branch February 19, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect type of function parameters
2 participants
@RahulGautamSingh @viceice