Skip to content

Commit

Permalink
docs(contributing): improve instructions for batch applying review su…
Browse files Browse the repository at this point in the history
…ggestions (#30829)
  • Loading branch information
HonkingGoose committed Aug 18, 2024
1 parent 0b8c14d commit 14cb0ec
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ And some options:
Please do not force push to your PR's branch after you have created your PR, as doing so forces us to review the whole PR again.
This makes it harder for us to review your work because we don't know what has changed.
PRs will always be squashed by us when we merge your work.
Commit as many times as you need in your pull request branch.
Commit as many times as you need in your pull request branch, but please batch apply review suggestions.

If you're updating your PR branch from within the GitHub PR interface, use the default "Update branch" button.
This is the "Update with merge commit" option in the dropdown.
Expand All @@ -83,7 +83,8 @@ Force pushing a PR, or using the "Update with rebase" button is OK when you:
## Apply maintainer provided review suggestions
Maintainers can suggest changes while reviewing your pull request, please follow these steps to apply them:
Maintainers can suggest changes while reviewing your pull request.
To apply these suggestions, please:
1. Batch the suggestions into a logical group by selecting the **Add suggestion to batch** button
1. Select the **Commit suggestions** button
Expand Down

0 comments on commit 14cb0ec

Please sign in to comment.