Skip to content

Commit

Permalink
fix(presets): match on devDependencies or dev for dev dependencies-re…
Browse files Browse the repository at this point in the history
…lated presets (#33909)

Co-authored-by: Rhys Arkins <rhys@arkins.net>
  • Loading branch information
alsyia and rarkins authored Jan 30, 2025
1 parent 9338455 commit 545bf31
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
4 changes: 3 additions & 1 deletion lib/config/presets/__snapshots__/index.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] =
"Add the \`renovate/\` prefix to all branch names.",
"Use semantic commit type \`fix\` for dependencies and \`chore\` for all others if semantic commits are in use.",
"Require all status checks to pass before any automerging.",
"Pin dependency versions for \`devDependencies\` and retain SemVer ranges for others.",
"Pin dependency versions for development dependencies and retain SemVer ranges for others.",
],
"ignoreTests": false,
"ignoreUnstable": true,
Expand Down Expand Up @@ -111,6 +111,8 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] =
{
"matchDepTypes": [
"devDependencies",
"dev-dependencies",
"dev",
],
"rangeStrategy": "pin",
},
Expand Down
12 changes: 6 additions & 6 deletions lib/config/presets/internal/default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ export const presets: Record<string, Preset> = {
description: 'Disable Renovate Dependency Dashboard creation.',
},
disableDevDependencies: {
description: 'Do not update `devDependencies` versions/ranges.',
description: 'Do not update development dependencies.',
packageRules: [
{
enabled: false,
matchDepTypes: ['devDependencies'],
matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'],
},
],
},
Expand Down Expand Up @@ -408,10 +408,10 @@ export const presets: Record<string, Preset> = {
],
},
pinDevDependencies: {
description: 'Pin dependency versions for `devDependencies`.',
description: 'Pin dependency versions for development dependencies.',
packageRules: [
{
matchDepTypes: ['devDependencies'],
matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'],
rangeStrategy: 'pin',
},
],
Expand All @@ -422,14 +422,14 @@ export const presets: Record<string, Preset> = {
},
pinOnlyDevDependencies: {
description:
'Pin dependency versions for `devDependencies` and retain SemVer ranges for others.',
'Pin dependency versions for development dependencies and retain SemVer ranges for others.',
packageRules: [
{
matchPackageNames: ['*'],
rangeStrategy: 'replace',
},
{
matchDepTypes: ['devDependencies'],
matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'],
rangeStrategy: 'pin',
},
{
Expand Down

0 comments on commit 545bf31

Please sign in to comment.