fix(manager/flux): skip local charts

renovatebot · Nov 5, 2024 · f49dd65 · f49dd65
1 parent 85267b9
commit f49dd65
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/lib/modules/manager/flux/extract.spec.ts b/lib/modules/manager/flux/extract.spec.ts
@@ -171,6 +171,34 @@ describe('modules/manager/flux/extract', () => {
       expect(result).toBeNull();
     });
 
+    it('skip HelmRelease with local chart', () => {
+      const result = extractPackageFile(
+        codeBlock`
+          apiVersion: helm.toolkit.fluxcd.io/v2beta1
+          kind: HelmRelease
+          metadata:
+            name: cert-manager-config
+            namespace: kube-system
+          spec:
+            chart:
+              spec:
+                chart: ./charts/cert-manager-config
+                sourceRef:
+                  kind: GitRepository
+                  name: chart-repo
+        `,
+        'test.yaml',
+      );
+      expect(result).toEqual({
+        deps: [
+          {
+            depName: './charts/cert-manager-config',
+            skipReason: 'local-chart',
+          },
+        ],
+      });
+    });
+
     it('does not match HelmRelease resources without a namespace to HelmRepository resources without a namespace', () => {
       const result = extractPackageFile(
         codeBlock`

diff --git a/lib/modules/manager/flux/extract.ts b/lib/modules/manager/flux/extract.ts
@@ -126,12 +126,20 @@ function resolveResourceManifest(
   for (const resource of manifest.resources) {
     switch (resource.kind) {
       case 'HelmRelease': {
+        const depName = resource.spec.chart.spec.chart;
         const dep: PackageDependency = {
-          depName: resource.spec.chart.spec.chart,
+          depName,
           currentValue: resource.spec.chart.spec.version,
           datasource: HelmDatasource.id,
         };
 
+        if (depName.startsWith('./')) {
+          dep.skipReason = 'local-chart';
+          delete dep.datasource;
+          deps.push(dep);
+          continue;
+        }
+
         const matchingRepositories = helmRepositories.filter(
           (rep) =>
             rep.kind === resource.spec.chart.spec.sourceRef?.kind &&