prNotPendingHours not honoured

[martinbonnin]

What Renovate type, platform and version are you using?

Using the hosted renovate App on https://github.com/apollographql/apollo-android/ (renovate.json here)

Describe the bug

prNotPendingHours is not honoured. Despite having set prNotPendingHours=1, the PR never gets created. The logs show:

Branch is 3 hours old - skipping PR creation

Relevant debug logs

From https://app.renovatebot.com/dashboard#github/apollographql/apollo-android/316803136:

Checking branch combined status(branch="renovate/documentation-infrastructure")
DEBUG: getBranchStatus(renovate/documentation-infrastructure)(branch="renovate/documentation-infrastructure")
DEBUG: branch status check result(branch="renovate/documentation-infrastructure")
{
  "state": "pending",
  "statuses": []
}
DEBUG: No check runs found(branch="renovate/documentation-infrastructure")
{
  "result": {
    "total_count": 0,
    "check_runs": []
  }
}
DEBUG: getBranchStatus() result(branch="renovate/documentation-infrastructure")
{
  "branchStatus": "yellow",
  "branchName": "renovate/documentation-infrastructure"
}
DEBUG: Branch status is "yellow" - checking timeout(branch="renovate/documentation-infrastructure")
DEBUG: Branch is 3 hours old - skipping PR creation(branch="renovate/documentation-infrastructure")
DEBUG: processBranch with 1 upgrades(branch="renovate/documentation-theme")
DEBUG: Setting current branch to main

Dashboard: apollographql/apollo-kotlin#2835

Clicking the box schedules the PR correctly but the PR never gets created automatically.

[rarkins]

According to this log, you don't have any check runs or status checks being run on the branch. Can you confirm if that's correct?

So is your goal that you set prNotPendingHours=1 so that the branch times out with no tests (i.e. pending) and then creates a PR so that tests can be run?

[martinbonnin]

According to this log, you don't have any check runs or status checks being run on the branch. Can you confirm if that's correct?

I'm not 100% sure how to check this on branches (vs pull requests where they show in the pull request) but I believe that's correct. We have a github action workflow that we disable for updates to docs (that typically come from renovate) to save some Action time.

So is your goal that you set prNotPendingHours=1 so that the branch times out with no tests (i.e. pending) and then creates a PR so that tests can be run?

Yep exactly.

[rarkins]

Tracing the logic, it passes this line:

renovate/lib/workers/pr/index.ts

Line 209 in 926f23f

`Branch status is "${await getBranchStatus()}" - checking timeout`

And then:

renovate/lib/workers/pr/index.ts

Line 223 in 926f23f

`Branch is ${elapsedHours} hours old - skipping PR creation`

So either elapsedHours < config.prNotPendingHours (in which caseconfig.prNotPendingHours is >= 3 and not 1 as we think) or config.stabilityStatus !== BranchStatus.yellow.

I'm not sure why that is but have added a non-null check to config.stabilityStatus.

[martinbonnin]

Looks like that would work, thanks! Our renovate jobs are still using 24.81.0 and the fix is in 24.81.1, can I force the renovate version to 24.81.1 somewhere or is it going to be updated automatically at some point?

[rarkins]

It will be updated automatically soon

[martinbonnin]

That worked 🎉: apollographql/apollo-kotlin#3001
Thanks!