Welcome to Renovate Message says it'll update dependencies and doesn't

[busches]

I recently onboarded a private repository to use Renovate and in the welcome to renovate PR it says it's going to upgrade a bunch of dependencies, some of which are Kotlin Gradle Plugins, example:
Update dependency org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin to v1.4.31

Once we merged the PR, none of the plugins were updated.

Sample Plugin in build.gradle.kts:

plugins {
    id("org.springframework.boot") version "2.4.3"
    id("io.spring.dependency-management") version "1.0.11.RELEASE"
    id("org.jmailen.kotlinter") version "3.3.0"
    kotlin("jvm") version "1.4.21" // All of these can move to 1.4.30 and that's what the welcome PR said
    kotlin("plugin.spring") version "1.4.21"
    kotlin("plugin.jpa") version "1.4.21"
    kotlin("kapt") version "1.4.21"
}

It did correctly find and update id("org.springframework.boot") version "2.4.3" to version 2.4.4, so it's not ignoring all plugins, just the kotlin ones.

We've made no changes to the Renovate configuration for this repo, so I'm confused on why the welcome PR would say it's going to open multiple PRs and in the end it opened two.

We are running Renovate 24.55.0

[rarkins]

1. Can you try adding the preset :switchToGradleLite and see if that works fully instead?
2. If not, can you create a minimal reproduction repository for debugging against?

My guess is that it tries to update and fails.

[busches]

Here is a repo that will reproduce the issue: https://github.com/busches/spring-boot-issue/blob/master/spring-boot-2.2/build.gradle.kts
I will give 1 a whirl and report back.

[rarkins]

Does it only fail if you have ~10 dependencies or can it be reproduced with less?

[busches]

10 to update or 10 total?

[busches]

Here's a smaller repo that should reproduce it as well, https://github.com/busches/renovate-bug renovate ran while it was still empty, so need to wait for it to trigger again.

[busches]

Here's the Welcome to Renovate PR: busches/renovate-bug#1
It thinks it's going to update four dependencies:

Update dependency org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin to v1.4.31
Update dependency org.jetbrains.kotlin.plugin.spring:org.jetbrains.kotlin.plugin.spring.gradle.plugin to v1.4.31
Update dependency org.jetbrains.kotlin:kotlin-allopen to v1.4.31 <-- This does not exist
Update dependency org.jetbrains.kotlin:kotlin-scripting-compiler-embeddable to v1.4.31 <-- Neither does this

Not sure where two of the dependencies are coming from.

Here is a bot run again against the repo: https://app.renovatebot.com/dashboard#github/busches/renovate-bug/319836246

Looking at just the jvm update we can see it finds the update, but then thinks there are no files to update:

DEBUG: getBranchPr(renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x)(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: findPr(renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x, undefined, open)(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: branchExists=false(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: Branch has 1 upgrade(s)(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: recreateClosed is false(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: findPr(renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x, Update dependency org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin to v1.4.31, !open)(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: prAlreadyExisted=false(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: Checking schedule(at any time, null)(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: No schedule defined(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: Branch needs creating(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: Using reuseExistingBranch: false(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: manager.getUpdatedPackageFiles() reuseExistinbranch=false(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: gradle.updateDependency(): packageFile:settings.gradle.kts depName:org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin, version:1.4.21 ==> 1.4.31(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: gradle.updateDependency(): packageFile:build.gradle.kts depName:org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin, version:1.4.21 ==> 1.4.31(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: No package files need updating(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: No updated lock files in branch(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")
DEBUG: No files to commit(branch="renovate/org.jetbrains.kotlin.jvm-org.jetbrains.kotlin.jvm.gradle.plugin-1.x")

Hopefully this is enough for you to go off of.

[rarkins]

This seems fixed by switching to gradle-lite. See https://github.com/renovate-tests/renovate-bug/pulls and please confirm

Note: looks like those two should be grouped by config, if they should be updated in lockstep

[busches]

That looks good. Any reason why it's not working with the docker image?

INFO: Repository started (repository=my-repo/repo)
       "renovateVersion": "24.55.0"
 INFO: Throwing preset error (repository=my-repo/repo)
       "validationError": "Cannot find preset's package (:switchToGradleLite)"
 INFO: Repository has invalid config (repository=my-repo/repo)
       "error": {
         "validationError": "Cannot find preset's package (:switchToGradleLite)",
         "message": "config-validation",
         "stack": "Error: config-validation\n    at Object.resolveConfigPresets (/usr/src/app/node_modules/renovate/lib/config/presets/index.ts:233:25)\n    at mergeRenovateConfig (/usr/src/app/node_modules/renovate/lib/workers/repository/init/config.ts:190:5)\n    at Object.getRepoConfig (/usr/src/app/node_modules/renovate/lib/workers/repository/init/config.ts:236:12)\n    at Object.initRepo (/usr/src/app/node_modules/renovate/lib/workers/repository/init/index.ts:21:12)\n    at Object.renovateRepository (/usr/src/app/node_modules/renovate/lib/workers/repository/index.ts:41:14)\n    at Object.start (/usr/src/app/node_modules/renovate/lib/workers/global/index.ts:68:7)\n    at /usr/src/app/node_modules/renovate/lib/renovate.ts:10:22"
       }
 INFO: Issue created (repository=my-repo/repo)
 WARN: Config Warning (repository=my-repo/repo)
       "configError": {
         "validationError": "Cannot find preset's package (:switchToGradleLite)",
         "message": "config-validation",
         "stack": "Error: config-validation\n    at Object.resolveConfigPresets (/usr/src/app/node_modules/renovate/lib/config/presets/index.ts:233:25)\n    at mergeRenovateConfig (/usr/src/app/node_modules/renovate/lib/workers/repository/init/config.ts:190:5)\n    at Object.getRepoConfig (/usr/src/app/node_modules/renovate/lib/workers/repository/init/config.ts:236:12)\n    at Object.initRepo (/usr/src/app/node_modules/renovate/lib/workers/repository/init/index.ts:21:12)\n    at Object.renovateRepository (/usr/src/app/node_modules/renovate/lib/workers/repository/index.ts:41:14)\n    at Object.start (/usr/src/app/node_modules/renovate/lib/workers/global/index.ts:68:7)\n    at /usr/src/app/node_modules/renovate/lib/renovate.ts:10:22"
       },
       "res": "created"
 INFO: Repository finished (repository=my-repo/repo)

Repo config still includes the schema definition, which is the only difference from your config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:base",
    ":switchToGradleLite"
  ]
}

[busches]

Looks like it wasn't enabled until 24.76.0, let me get ours updated. 30537d6