Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate spam GitHub issues #10902

Closed
2 of 11 tasks
oliviertassinari opened this issue Jul 20, 2021 · 13 comments · Fixed by #11133 or #11214
Closed
2 of 11 tasks

Renovate spam GitHub issues #10902

oliviertassinari opened this issue Jul 20, 2021 · 13 comments · Fixed by #11133 or #11214
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:bug Bug fix of existing functionality

Comments

@oliviertassinari
Copy link
Contributor

  • WhiteSource Renovate hosted app on github.com
  • Self hosted

If using the hosted app, please skip to the next section.
Otherwise, if self-hosted, please complete the following:

Please select which platform you are using:

  • Azure DevOps (dev.azure.com)
  • Azure DevOps Server
  • Bitbucket Cloud (bitbucket.org)
  • Bitbucket Server
  • Gitea
  • github.com
  • GitHub Enterprise Server
  • gitlab.com
  • GitLab self-hosted

Renovate version: any

Describe the bug

Renovate opens pull requests linking the PRs on the changelog without any proxies. This makes the work of the maintainers harder. We can no longer easily find all the related effort to a given issue.

Have you created a minimal reproduction repository?

See https://github.com/mui-org/material-ui/issues/27170

Capture d’écran 2021-07-20 à 12 34 21

@oliviertassinari oliviertassinari added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Jul 20, 2021
@rarkins
Copy link
Collaborator

rarkins commented Jul 20, 2021

Strange - must be a pattern which our sanitizers miss. Also strange that it's an open issue being referenced in a changelog. We need to locate the backlink in the PRs, then locate the raw changelog it's derived from, and then fix our sanitisation.

@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Jul 20, 2021
@oliviertassinari
Copy link
Contributor Author

@rarkins I assume it's because of this link in the changelog: https://github.com/mui-org/material-ui/blame/next/CHANGELOG.md#L16

@rarkins
Copy link
Collaborator

rarkins commented Jul 20, 2021

@zharinov Could you take a look?

@zharinov
Copy link
Collaborator

@zharinov Could you take a look?

Okay

@rarkins
Copy link
Collaborator

rarkins commented Jul 20, 2021

Please test in private repos so that we don't increase the back links any further. I know if you delete a link then the backlink still remains, although maybe if you delete the whole repo then it disappears.

@zharinov
Copy link
Collaborator

Yes, the whole repo deletion works, while link deletion isn't

@rarkins
Copy link
Collaborator

rarkins commented Jul 20, 2021

Maybe the "." at the end of that link fools the linkify we use? There just be something special about that link because the others seem fine and we haven't had a link spam complaint in at least a year

@zharinov
Copy link
Collaborator

zharinov commented Jul 20, 2021

Hi @oliviertassinari, did you notice another occurrences of this bug for other issues? We think it has something to do with markdown parsing of particular line you mentioned in the CHANGELOG.md.

@oliviertassinari
Copy link
Contributor Author

Not I can think of. Happy to hear that it's an isolated/edge-case issue.

@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Jul 26, 2021
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.69.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oliviertassinari
Copy link
Contributor Author

Thanks for the fix

@rarkins
Copy link
Collaborator

rarkins commented Aug 10, 2021

We need to unfortunately reopen this due to a regression error causing mui/material-ui#11133 to be reverted

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.72.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:bug Bug fix of existing functionality
Projects
None yet
4 participants