fix(github): Better massageMarkdown implementation #11133
Conversation
|
Example: renovate-testing/test-10902-markdown-github-links-1#1 (open release notes, search for "our progress") |
package.json
Outdated
| @@ -167,6 +167,8 @@ | |||
| "luxon": "2.0.1", | |||
| "markdown-it": "12.1.0", | |||
| "markdown-table": "2.0.0", | |||
| "mdast-util-find-and-replace": "1.0.0", | |||
| "mdast-util-to-string": "1.0.0", | |||
There was a problem hiding this comment.
Same versions as for remark-github
There was a problem hiding this comment.
remark-github seems to use ^1.0.0 which not points to some higher version, check lockfile changes below
| import findAndReplace from 'mdast-util-find-and-replace'; | ||
| import remark from 'remark'; | ||
| import type { Plugin, Transformer } from 'unified'; | ||
| // eslint-disable-next-line import/no-unresolved |
There was a problem hiding this comment.
@types/unist exists in NPM while unist doesn't 🤷♂️
| import findAndReplace from 'mdast-util-find-and-replace'; | ||
| import remark from 'remark'; | ||
| import type { Plugin, Transformer } from 'unified'; | ||
| // eslint-disable-next-line import/no-unresolved |
| }); | ||
| } | ||
|
|
||
| const githubExtra: Plugin<any> = (): Transformer => transformer; |
There was a problem hiding this comment.
Just didn't want to write this lambda in .use(...) expression
package.json
Outdated
| @@ -167,6 +167,8 @@ | |||
| "luxon": "2.0.1", | |||
| "markdown-it": "12.1.0", | |||
| "markdown-table": "2.0.0", | |||
| "mdast-util-find-and-replace": "1.0.0", | |||
| "mdast-util-to-string": "1.0.0", | |||
There was a problem hiding this comment.
remark-github seems to use ^1.0.0 which not points to some higher version, check lockfile changes below
|
Updated new dependencies to the latest version before ESM transition |
|
But are we adding dependencies now which we can't upgrade later due to ESM? |
|
Yes, it's a sad part. If I understand it right, we're making them explicit. I mean, it's just what |
|
🎉 This PR is included in version 25.69.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@zharinov This broke some release notes https://github.com/visualon/docker-docuum/releases/v0.20.3
### Release Notes
<details>
<summary>visualon/docker-docuum</summary>
### [`v0.20.3`](https://github.com/visualon/docker-docuum/releases/v0.20.3)
[Compare Source](https://github.com/visualon/docker-docuum/compare/v0.20.2...v0.20.3)
See [https://github.com/stepchowfun/docuum/releases/tag/v0](https://github.com/stepchowfun/docuum/releases/tag/v0).20.3 for more changes
</details> |
|
Seems like the |
Changes:
Implement
remarkplugin inspired by remark-github.Type declarations aren't ideal, but any interaction with syntax-tree packages is painful since we can't install fresh ESM-only packages.
Context:
Closes #10902
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: