Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn migratePresets into a non-self-hosted property #16605

Open
Tracked by #19289
astellingwerf opened this issue Jul 15, 2022 · 8 comments
Open
Tracked by #19289

Turn migratePresets into a non-self-hosted property #16605

astellingwerf opened this issue Jul 15, 2022 · 8 comments
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@astellingwerf
Copy link
Collaborator

What would you like Renovate to be able to do?

The property migratePresets can be used to migrate presets (shocker, I know!). Today, the property is a self-hosted property. I'd like to suggest that I'd would be of more use if the property could also be set in a repo or preset context. More specifically: whenever implementable, it should be possible for a "legacy" preset to include a migratePresets declaration about itself and its replacement, in order to auto-discover the new prefered situation.

If you have any ideas on how this should be implemented, please tell us here.

Not really.

Is this a feature you are interested in implementing yourself?

Maybe

@astellingwerf astellingwerf added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Jul 15, 2022
@rarkins rarkins added core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Jul 15, 2022
@viceice
Copy link
Member

viceice commented Jul 16, 2022

doesn't make sense, as you still need to run renovate on it.

so the request would be to allow migrating presets instead. so please update issue

@astellingwerf
Copy link
Collaborator Author

That's what configMigration=true achieves if migratePresets is also set. I don't see a reason to update the issue.

@rarkins
Copy link
Collaborator

rarkins commented Jul 16, 2022

So I think ideally it would have been called something like "remapPresets" because it doesn't migrate anything itself per se. But now that we have it, is it work renaming it?

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Dec 7, 2022

If the current name is confusing we should pick a better name, even if that means more work. Good names help to understand what the bot is going to do. 😄


Edit: I see we also mention remapPresets in this issue:

Do you want a new issue to track renaming migratePresets to remapPresets?

@rarkins
Copy link
Collaborator

rarkins commented Dec 7, 2022

Yes, let's have a separate issue. We need to remember to migrate self-hosted config in this case

@HonkingGoose
Copy link
Collaborator

Yes, let's have a separate issue.

Done, see:

We need to remember to migrate self-hosted config in this case

Can you tell me where that todo belongs? I don't understand if it's for this issue or the new separate issue. 🙈

@rarkins
Copy link
Collaborator

rarkins commented Dec 7, 2022

Within the same issue

@rarkins rarkins removed the status:requirements Full requirements are not yet known, so implementation should not be started label Oct 1, 2023
@Finkregh
Copy link
Contributor

Finkregh commented Aug 6, 2024

This would be really helpful, as it would allow rename files:

  • enable configMigration in the "old" file (yes, might lead to other PRs being created, but that's OK in my case)
  • set migratePresets in the "old" file to reference the new/renamed file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

5 participants