-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix Renovate config #3635
chore: Fix Renovate config #3635
Conversation
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Added the renovate-config-validator as a required pre-submit check on the branch protection rule. |
Hi @ianlewis 👋 I see you have a lot of questions about Renovate. I help maintain the Renovate docs, so I'm taking a shot at helping you. I hope you find this information helpful. 😉
|
@HonkingGoose thanks for the pointers. I did find those docs aside from the release notes. I was a bit surprised that renovate reopened an old issue when the config was invalid instead of opening a new one. This meant that it was buried in the issues list and I missed it. I was also surprised that the dashboard didn't include anything about the config errors so I was led down the wrong path for a while. It would be kind of cool if renovate could automatically send PRs to fix some common issues (like the 4 am thing) with it's config or send PRs to migrate old deprecated config. Maybe that's wishful thinking though :) |
You're welcome! Thanks for actually reading (most) of the docs! ❤️ There's a lot to read so I don't expect you to read all. 😄 Subscribe to the Renovate discussion
I don't know enough to answer these questions. Please subscribe to this discussion: Edit: Here's a PR that allows Renovate to create a new config warning issue: Renovate can open config migration PRs (experimental feature)
You're in luck, Renovate can already migrate old stuff in your config. This is an experimental feature, so it may only work partially. Review config migration PRs, before merging them. Read the Renovate docs, I guess the Issues related to
|
# Summary - Set `configWarningReuseIssue` to `false`. Old behavior: Renovate re-opens a old config warning issue. New behavior: Renovate creates a new config warning issue. Read the [Renovate docs, `configWarningReuseIssue` config option](https://docs.renovatebot.com/configuration-options/#configwarningreuseissue) to learn more. ## More context @ianlewis mentioned they want Renovate to create a _new issue_ instead of _re-opening_ an old one: - #3635 (comment) Here's an example of a Renovate config warning issue that was re-opened by Renovate recently: - #404 ## Testing Process - Manually reviewed configuration change ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [ ] Update documentation if applicable. - [ ] Add unit tests if applicable. - [ ] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. Signed-off-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Summary
Fixes renovate config to use the
config:best-practices
preset rather than theconfig:base
preset sinceconfig:base
seems to have gone away at some point.Also fixes the
schedule
config by using theschedule:monthly
preset. The previousschedule
config seems to have been invalid because "4 am" had space between "4" and "am" (this was fixed in theslsa-verifier
repo on slsa-framework/slsa-verifier#727 but was never fixed here).Also adds a pre-submit to run the
renovate-config-validator
to ensure that renovate config is valid. This pre-submit will need to be made required in the repository branch protection rule formain
in the repository settings after this PR is merged.Fixes #3634 #404
Testing Process
make renovate-config-validator
to check that the config is valid.Checklist