Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuget): Support version ranges #26150

Merged
merged 42 commits into from
Aug 15, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Dec 6, 2023

Changes

Reimplement nuget versioning with support for ranges.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as draft December 6, 2023 04:05
lib/modules/versioning/nuget/compare.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/compare.ts Outdated Show resolved Hide resolved
@zharinov zharinov marked this pull request as ready for review December 8, 2023 03:45
@zharinov
Copy link
Collaborator Author

zharinov commented Dec 8, 2023

Results from log:

{
  "datasource": "nuget",
  "depType": "nuget",
  "depName": "Microsoft.Extensions.Configuration",
  "currentValue": "6.0.*",
  "updates": [
    {
      "bucket": "major",
      "newVersion": "8.0.0",
      "newValue": "8.0.*",
      "releaseTimestamp": "2023-11-14T13:22:38.957Z",
      "newMajor": 8,
      "newMinor": 0,
      "updateType": "major",
      "isRange": true,
      "branchName": "renovate/major-dotnet-monorepo"
    }
  ],
  "packageName": "Microsoft.Extensions.Configuration",
  "versioning": "nuget",
  "warnings": [],
  "sourceUrl": "https://github.com/dotnet/runtime",
  "registryUrl": "https://api.nuget.org/v3/index.json",
  "homepage": "https://dot.net/",
  "currentVersion": "6.0.1",
  "isSingleVersion": false
}

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More isValid() tests needed

lib/modules/versioning/nuget/compare.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/compare.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/index.ts Show resolved Hide resolved
@darthkurak

This comment was marked as spam.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't 1.2.3.4.5 also a valid nuget version? 🤔

lib/modules/versioning/nuget/index.ts Show resolved Hide resolved
lib/modules/versioning/nuget/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/types.ts Outdated Show resolved Hide resolved
lib/modules/versioning/nuget/version.ts Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Jul 26, 2024

@zharinov
Copy link
Collaborator Author

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme needs an update 🙃

@zharinov zharinov requested a review from viceice August 5, 2024 13:26
@viceice
Copy link
Member

viceice commented Aug 11, 2024

@rarkins please review or approve

@viceice viceice enabled auto-merge August 12, 2024 06:30
@viceice viceice added this pull request to the merge queue Aug 15, 2024
Merged via the queue into renovatebot:main with commit 927f749 Aug 15, 2024
38 checks passed
@viceice viceice deleted the feat/nuget-ranges-support branch August 15, 2024 12:47
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kosmoz pushed a commit to kosmoz/renovate that referenced this pull request Aug 16, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants