Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerabilities): do not force exact patch version for NuGet datasource #31127

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Aug 30, 2024

Changes

PR #26150 added support for NuGet version ranges and thereby unlocked the possibility to also use them as version constraints in vulnerability fix PRs.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repos:

@rarkins
Copy link
Collaborator

rarkins commented Aug 30, 2024

Does Nuget versioning support this syntax?

@Churro
Copy link
Collaborator Author

Churro commented Aug 31, 2024

Does Nuget versioning support this syntax?

Yes, there is also a test for exactly the same range format used in this PR:

it('parses range without upper bound', () => {
expect(parseBracketRange('[1.2.3,)')).toEqual({
type: 'nuget-bracket-range',
min: { type: 'nuget-version', major: 1, minor: 2, patch: 3 },
max: undefined,
minInclusive: true,
maxInclusive: false,
});
});

@rarkins
Copy link
Collaborator

rarkins commented Aug 31, 2024

Great. Have you been able to verify that this works "end to end" in a real repo?

@Churro
Copy link
Collaborator Author

Churro commented Aug 31, 2024

Great. Have you been able to verify that this works "end to end" in a real repo?

Yes, therefore I've linked two test repos (see above)

@rarkins
Copy link
Collaborator

rarkins commented Aug 31, 2024

Sorry, I should have checked more closely (on mobile, it was hidden by default)

@rarkins rarkins enabled auto-merge August 31, 2024 12:53
@rarkins rarkins added this pull request to the merge queue Aug 31, 2024
Merged via the queue into renovatebot:main with commit fbdb8c2 Aug 31, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.59.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants