Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hex): support update-lockfile strategy #27915

Merged

Conversation

pdm-jd
Copy link
Contributor

@pdm-jd pdm-jd commented Mar 13, 2024

Changes

  • Support rangeStrategy=update-lockfile for the mix manager
  • Fixed fixture mix.exs to have a realistic structure - no duplicate dependencies with different versions

Context

Closes #13618

Depends on #27924

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

It looks like the documentation for Hex versioning should automatically update to include update-lockfile, based on tools/docs/versioning.ts

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Example PRs created with this code for these dependencies https://github.com/pdm-jd/renovate-mix-tests/pulls

  defp deps do
    [
      {:tesla, "~> 1.4"},
      {:poison, "~> 4.0"}
    ]
  end

image

@viceice viceice changed the title feat(hex): support update-lockfile strategy feat(mix): support update-lockfile strategy Mar 13, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split this PR in a manager and a versioning part.

lib/modules/manager/mix/__fixtures__/mix.exs Outdated Show resolved Hide resolved
@pdm-jd
Copy link
Contributor Author

pdm-jd commented Mar 13, 2024

please split this PR in a manager and a versioning part.

@viceice to confirm, would you like me to close this one and submit two PRs that reference this one?

@viceice
Copy link
Member

viceice commented Mar 13, 2024

no, just create one new PR with the changes which need to be merged first. currently don't see if it's versioning or manager, so decide yourself.

@pdm-jd pdm-jd mentioned this pull request Mar 13, 2024
6 tasks
@pdm-jd pdm-jd changed the title feat(mix): support update-lockfile strategy feat(hex): support update-lockfile strategy Mar 14, 2024
@pdm-jd pdm-jd requested a review from viceice March 14, 2024 18:33
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by #27924

@pdm-jd
Copy link
Contributor Author

pdm-jd commented Jun 5, 2024

This is ready for re-review. I've validated it still works as expected with the code.

Reference: https://github.com/pdm-jd/renovate-mix-tests/pulls

image

@pdm-jd pdm-jd requested a review from viceice June 5, 2024 16:50
@pdm-jd pdm-jd requested a review from viceice June 11, 2024 16:33
@rarkins rarkins added this pull request to the merge queue Jun 12, 2024
Merged via the queue into renovatebot:main with commit 4c3d970 Jun 12, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.405.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kosmoz pushed a commit to kosmoz/renovate that referenced this pull request Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supporting rangeStrategy=update-lockfile with mix manager
4 participants