Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mix): extract lockedVersion #27924

Merged
merged 17 commits into from
May 27, 2024
Merged

feat(mix): extract lockedVersion #27924

merged 17 commits into from
May 27, 2024

Conversation

pdm-jd
Copy link
Contributor

@pdm-jd pdm-jd commented Mar 13, 2024 •
edited by viceice
Loading

Changes

Preliminary changes to the mix manager to support the update-lockfile versioning strategy. A separate PR for the manager and versioning portions was requested by @viceice

Parent PR: #27915

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The changes only work by running with the versioning strategy changes in the parent PR as well.

@pdm-jd pdm-jd changed the title Feat/mix/support for update lockfile strategy feat(mix): support to add update-lockfile strategy Mar 13, 2024
@pdm-jd
Copy link
Contributor Author

pdm-jd commented Mar 14, 2024

@rarkins I saw you just ran CI on this, thanks! The codecov job failed because it couldn't upload. Would it be possible to re-run?

@pdm-jd pdm-jd mentioned this pull request Mar 14, 2024
Merged
6 tasks
viceice
viceice reviewed Mar 15, 2024
View reviewed changes
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/util/pretty-time.spec.ts Outdated Show resolved Hide resolved
@pdm-jd pdm-jd requested a review from viceice March 15, 2024 17:09
viceice
viceice reviewed Mar 15, 2024
View reviewed changes
lib/modules/manager/mix/extract.ts Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins mentioned this pull request Mar 20, 2024
Closed
@pdm-jd pdm-jd requested a review from viceice March 26, 2024 21:48
viceice
viceice reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

lib/modules/manager/mix/extract.spec.ts Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
@pdm-jd pdm-jd requested a review from viceice April 1, 2024 17:51
viceice
viceice reviewed Apr 8, 2024
View reviewed changes
lib/modules/manager/mix/extract.ts Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
@pdm-jd pdm-jd requested a review from viceice April 8, 2024 23:01
viceice
viceice reviewed Apr 9, 2024
View reviewed changes
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mix/extract.ts Outdated Show resolved Hide resolved
@pdm-jd pdm-jd requested a review from viceice May 10, 2024 03:55
@pdm-jd pdm-jd requested a review from viceice May 17, 2024 20:29
@viceice viceice changed the title feat(mix): support to add update-lockfile strategy feat(mix): extract lockedVersion from lockfile May 27, 2024
@viceice viceice changed the title feat(mix): extract lockedVersion from lockfile feat(mix): extract lockedVersion May 27, 2024
@viceice viceice requested review from rarkins and secustor May 27, 2024 13:14
@rarkins rarkins added this pull request to the merge queue May 27, 2024
Merged via the queue into renovatebot:main with commit 30926c9 May 27, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.379.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

@secustor secustor Awaiting requested review from secustor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdm-jd @renovate-release @viceice @rarkins