-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tool detection to renovatebot/detect-tools #29000
Comments
🎉 This issue has been resolved in version 38.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
we only fixed a single manager |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I don't like how its scope is unclear, while refactoring each of the remaining managers seems to be quite laborous. Let's close this one and create new ones on per-manager basis. |
why not using this as the meta issue with a to-do list of sub issues? so we've an overview. |
Because I feel more satisfied when PR closes the issue rather than just checking the box 🙂 |
that's why I suggest to have an uber issue and then create an issue for each manager listed as task list inside the uber issue |
Here we go, I just created tracking issue |
Describe the proposed change(s).
We should move tool detection to a separate repo/module so that it can be shared outside Renovate, particularly with some Containerbase tooling we are building.
Start with Poetry and Pipenv.
Example from: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/pipenv/artifacts.ts
Instead of a
getPythonConstraint()
function where we pass content to the function, we should instead call our new external library and pass it a fully qualified path/directory.The text was updated successfully, but these errors were encountered: