Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tool detection to renovatebot/detect-tools #29000

Closed
Tracked by #31065
rarkins opened this issue May 11, 2024 · 9 comments · Fixed by #29787
Closed
Tracked by #31065

Move tool detection to renovatebot/detect-tools #29000

rarkins opened this issue May 11, 2024 · 9 comments · Fixed by #29787
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2024

Describe the proposed change(s).

We should move tool detection to a separate repo/module so that it can be shared outside Renovate, particularly with some Containerbase tooling we are building.

Start with Poetry and Pipenv.

Example from: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/pipenv/artifacts.ts

Instead of a getPythonConstraint() function where we pass content to the function, we should instead call our new external library and pass it a fully qualified path/directory.

@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code labels May 11, 2024
@rarkins rarkins added the status:in-progress Someone is working on implementation label Jul 1, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice reopened this Aug 16, 2024
@viceice
Copy link
Member

viceice commented Aug 16, 2024

we only fixed a single manager

@sspans-sbp

This comment has been minimized.

@viceice

This comment has been minimized.

@zharinov
Copy link
Collaborator

we only fixed a single manager

I don't like how its scope is unclear, while refactoring each of the remaining managers seems to be quite laborous. Let's close this one and create new ones on per-manager basis.

@viceice
Copy link
Member

viceice commented Aug 26, 2024

why not using this as the meta issue with a to-do list of sub issues? so we've an overview.

@zharinov
Copy link
Collaborator

Because I feel more satisfied when PR closes the issue rather than just checking the box 🙂

@viceice
Copy link
Member

viceice commented Aug 27, 2024

that's why I suggest to have an uber issue and then create an issue for each manager listed as task list inside the uber issue

@zharinov
Copy link
Collaborator

Here we go, I just created tracking issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants