Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipenv): Use @renovatebot/detect-tools for constraints detection #29787

Merged
merged 33 commits into from
Aug 16, 2024
Merged

feat(pipenv): Use @renovatebot/detect-tools for constraints detection #29787

merged 33 commits into from
Aug 16, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 20, 2024 •
edited

Changes

Use drop-in library replacement for pypi constraint detection.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title feat(pipenv): Use "@renovatebot/detect-tools" for constraints detection feat(pipenv): Use "detect-tools" for constraints detection Jun 20, 2024
@zharinov zharinov marked this pull request as draft June 21, 2024 15:20
@zharinov zharinov marked this pull request as ready for review July 1, 2024 13:48
@zharinov zharinov marked this pull request as draft July 1, 2024 14:19
@zharinov zharinov marked this pull request as ready for review July 2, 2024 16:36
@zharinov zharinov added the ci:fulltest Run full test suite on all platforms label Jul 2, 2024
@zharinov zharinov marked this pull request as draft July 2, 2024 16:37
@zharinov zharinov marked this pull request as ready for review July 2, 2024 16:37
@zharinov zharinov requested review from rarkins and viceice July 2, 2024 16:54
viceice
viceice reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new code looks promising, please also let me review changes to the detect tools. I need them later for containerbase.

lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice July 15, 2024 14:55
@zharinov zharinov marked this pull request as draft July 15, 2024 15:07
@zharinov zharinov marked this pull request as ready for review July 15, 2024 15:07
viceice
viceice reviewed Jul 26, 2024
View reviewed changes
lib/modules/manager/pipenv/schema.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice August 4, 2024 18:52
viceice
viceice reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate/lib/modules/manager/pipenv/extract.ts

Line 171 in 607d7e3

if (is.nonEmptyString(pipfile.requires?.python_version)) {

this should be replaced too

lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
@zharinov zharinov changed the title feat(pipenv): Use "detect-tools" for constraints detection feat(pipenv): Use @renovatebot/detect-tools for constraints detection Aug 5, 2024
@zharinov zharinov requested a review from viceice August 6, 2024 00:28
viceice
viceice reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/pipenv/extract.spec.ts Show resolved Hide resolved
@zharinov zharinov force-pushed the feat/pipenv-to-use-detect-tools branch from 583c6a1 to af430ce Compare August 15, 2024 12:33
@zharinov
Merge branch 'main' into feat/pipenv-to-use-detect-tools
af72b37 
# Conflicts:
#	lib/modules/manager/pipenv/artifacts.ts
@viceice viceice added this pull request to the merge queue Aug 16, 2024
Merged via the queue into renovatebot:main with commit c3cf91b Aug 16, 2024
51 checks passed
@viceice viceice deleted the feat/pipenv-to-use-detect-tools branch August 16, 2024 16:25
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move tool detection to renovatebot/detect-tools
3 participants
@zharinov @renovate-release @viceice