Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): treat v0 pseudo version updates as digest updates #29042

Merged
merged 12 commits into from
May 17, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 13, 2024

Changes

Based on minor, major and patch changes, detect digest update type.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins May 13, 2024 16:50
rarkins
rarkins previously approved these changes May 13, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/workers/repository/process/lookup/generate.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to check both versions start with v0.0.0, to be safest

@zharinov zharinov requested review from rarkins and viceice May 14, 2024 19:36
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more logical to locate this in the getBucket() function? I assume it won't happen in practice but in theory you could have both digest and patch updates separately

@zharinov zharinov requested a review from rarkins May 15, 2024 11:32
@zharinov
Copy link
Collaborator Author

Wouldn't it be more logical to locate this in the getBucket() function? I assume it won't happen in practice but in theory you could have both digest and patch updates separately

I saw getBucket() function, but it returns strings, so I'm not sure. Seems like there is no solution which isn't ugly, but maybe generateUpdate() is the better place. IMO it doesn't matter as far as we make it clear: this if-statement is the workaround.

@rarkins
Copy link
Collaborator

rarkins commented May 17, 2024

I realized that this would require us changing in both getBucket() and getUpdateType(), and both changes would still be essentially "hardcoded logic for go", so we may as well stick with the proposed solution here

@rarkins rarkins changed the title fix: Detect "digest" update type fix(gomod): treat v0 pseudo version updates as digest updates May 17, 2024
@rarkins rarkins added this pull request to the merge queue May 17, 2024
Merged via the queue into renovatebot:main with commit 6f8cde4 May 17, 2024
37 checks passed
@rarkins rarkins deleted the fix/gomod-digest-update-type branch May 17, 2024 05:32
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.368.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gomod dependency updates type are now patch (where digest before)
4 participants