-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gomod): treat v0 pseudo version updates as digest updates #29042
fix(gomod): treat v0 pseudo version updates as digest updates #29042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to check both versions start with v0.0.0, to be safest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be more logical to locate this in the getBucket() function? I assume it won't happen in practice but in theory you could have both digest and patch updates separately
I saw |
I realized that this would require us changing in both getBucket() and getUpdateType(), and both changes would still be essentially "hardcoded logic for go", so we may as well stick with the proposed solution here |
🎉 This PR is included in version 37.368.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Based on minor, major and patch changes, detect
digest
update type.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: