Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): add new opencost-ui to opencost monorepo #29547

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

MindTooth
Copy link
Contributor

Changes

In anticipation for opencost/opencost-ui#18 getting merged.

This adds the opencost-ui project as a separate repo for the opencost monorepo. They've desided to split the projects, but still under the same umbrella.

They are released in the same pipeline, using the same version: https://github.com/opencost/opencost/blob/develop/.github/workflows/build-and-publish-release.yml

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

I ran pnpm run lint.

@MindTooth MindTooth marked this pull request as draft June 8, 2024 20:28
@MindTooth
Copy link
Contributor Author

I've asked if they plan to do releases in opencost/opencost-ui repo as well, or else we won't be able to get a changelog. 🤔 Maybe it's not that important anyways. As we will get the changelog for opencost/opencost in the same PR.

@HonkingGoose
Copy link
Collaborator

@MindTooth by the way: the Renovate docs, key concepts page for changelogs has more info about getting Renovate to see and understand the changelogs. That may help getting changelogs functional for those packages.

@MindTooth MindTooth marked this pull request as ready for review June 11, 2024 07:28
Signed-off-by: Birger J. Nordølum <contact@mindtooth.no>
@MindTooth MindTooth force-pushed the fix/update_opencost_monorepo branch from 22f3bc6 to a058f6e Compare June 11, 2024 07:30
@MindTooth
Copy link
Contributor Author

I did a sin with force push, not sure how this works when files are renamed, sorry. 😔

opencost/opencost-ui#18 just got merged, so this is a go ahead.

I'm still at a loss on how changelog works after five years working with Renovate. MindTooth/renovate-opencost-test#5 does not pick up even when the log says it's fetching. 🤣

@MindTooth
Copy link
Contributor Author

ERROR: Coverage for lines (96.89%) does not meet global threshold (100%)
ERROR: Coverage for functions (96.49%) does not meet global threshold (100%)
ERROR: Coverage for branches (95.16%) does not meet global threshold (100%)
ERROR: Coverage for statements (96.91%) does not meet global threshold (100%)

Hmm. Not sure about this one? Locally I have:

=============================== Coverage summary ===============================
Statements   : 100% ( 41977/41977 )
Branches     : 100% ( 13238/13238 )
Functions    : 100% ( 5218/5218 )
Lines        : 100% ( 41389/41389 )
================================================================================

Test Suites: 722 passed, 722 total
Tests:       15008 passed, 15008 total
Snapshots:   732 passed, 732 total
Time:        166.06 s
Ran all test suites.

@rarkins rarkins merged commit f98e4dd into renovatebot:main Jun 11, 2024
33 of 37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.401.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

kosmoz pushed a commit to kosmoz/renovate that referenced this pull request Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants