-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(leiningen): support lein-parent #29552
Conversation
This commit adds support for 'parent-project' functionality, which is used by the [lein-parent][1] project. `:parent-project` is expected to specify a single dependency, under the `:coords` key. Two notable changes have been made to facilitate this: 1. `extractFromVectors` allows the vector dimension to be specified. This was previously assumed to be 2, but 1 has now been added to support single "bare" dependencies. I'm not aware of anything in the Lein ecosystem that would mandate values other than 1 or 2. 2. `collectDeps` accepts an options object for specifying whether the deps are nested (dimensions = 2) or not (dimensions = 1). It also allows specifying the `depType` explicitly, so we can have the relevant dependency at the path `[:parent-project :coords]` be labelled `parent-project`, rather than the less descriptive `coords` [1]: https://github.com/achin/lein-parent Relates to renovatebot#7815
lib/modules/manager/leiningen/__snapshots__/extract.spec.ts.snap
Outdated
Show resolved
Hide resolved
lib/modules/manager/leiningen/__snapshots__/extract.spec.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Hi there, You are using Good luck, The Renovate team |
🎉 This PR is included in version 37.409.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This commit adds support for 'parent-project' functionality, which is used by the lein-parent project.
:parent-project
is expected to specify a single dependency, under the:coords
key. Two notable changes have been made to facilitate this:extractFromVectors
allows the vector dimension to be specified. This was previously assumed to be 2, but 1 has now been added to support single "bare" dependencies. I'm not aware of anything in the Lein ecosystem that would mandate values other than 1 or 2.collectDeps
accepts an options object for specifying whether the deps are nested (dimensions = 2) or not (dimensions = 1). It also allows specifying thedepType
explicitly, so we can have the relevant dependency at the path[:parent-project :coords]
be labelledparent-project
, rather than the less descriptivecoords
Context
I have the same use-case as #7815
Documentation (please check one with an [x])
I can explicitly call out
lein-parent
support in the docs if desired.How I've tested my work (please select one)
I have verified these changes via: