refactor: Tidy Scala version normalization code #29642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added this code in extract.ts to detect Scala 3 versions but I did not realise there was already Scala version normalization happening in util.ts, so I've moved the logic there.
rarkins
approved these changes
Jun 13, 2024
rarkins
changed the title
|
🎉 This PR is included in version 37.407.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I added this code in extract.ts to detect Scala 3 versions but I did not realise there was already Scala version normalization happening in util.ts, so I've moved the logic there.
Context
I contributed code in #29291 but recently I realised it could be simplified.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: