-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbt): Support Scala 3 dependency resolution #29291
Merged
rarkins
merged 5 commits into
renovatebot:main
from
george-wilson-rea:scala3-dependency-versions
May 28, 2024
Merged
feat(sbt): Support Scala 3 dependency resolution #29291
rarkins
merged 5 commits into
renovatebot:main
from
george-wilson-rea:scala3-dependency-versions
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala 3 packages are suffixed by only the major version, `_3` rather than being suffixed by the major and minor version eg. `_2.13` closes renovatebot#29087
george-wilson-rea
changed the title
Support Scala 3 dependency resolution in sbt manager
feat: Support Scala 3 dependency resolution in sbt manager
May 28, 2024
rarkins
requested changes
May 28, 2024
viceice
changed the title
feat: Support Scala 3 dependency resolution in sbt manager
feat(sbt): Support Scala 3 dependency resolution
May 28, 2024
Simplify Scala 3 logic Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins
previously approved these changes
May 28, 2024
auto-merge was automatically disabled
May 28, 2024 05:45
Head branch was pushed to by a user without write access
Sorry for the churn; I needed to run |
rarkins
approved these changes
May 28, 2024
🎉 This PR is included in version 37.380.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Scala 2 packages have their artefact name suffixed by the major and minor version, eg.
_2.13
.Scala 3 packages are different - their names are suffixed by only the major version,
_3
rather than being suffixed by the major and minor version, eg._3.4
This change detects Scala 3 code and uses the correct shorter suffix.
Context
Closes #29087
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: