Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbt): Support Scala 3 dependency resolution #29291

Merged

Conversation

george-wilson-rea
Copy link
Contributor

Changes

Scala 2 packages have their artefact name suffixed by the major and minor version, eg. _2.13.
Scala 3 packages are different - their names are suffixed by only the major version, _3 rather than being suffixed by the major and minor version, eg. _3.4

This change detects Scala 3 code and uses the correct shorter suffix.

Context

Closes #29087

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required
  • I'm not sure, but I'm happy to update documentation if necessary

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Scala 3 packages are suffixed by only the major version, `_3` rather than
being suffixed by the major and minor version eg. `_2.13`

closes renovatebot#29087
@george-wilson-rea george-wilson-rea changed the title Support Scala 3 dependency resolution in sbt manager feat: Support Scala 3 dependency resolution in sbt manager May 28, 2024
lib/modules/manager/sbt/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/sbt/extract.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title feat: Support Scala 3 dependency resolution in sbt manager feat(sbt): Support Scala 3 dependency resolution May 28, 2024
Simplify Scala 3 logic

Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins
rarkins previously approved these changes May 28, 2024
@rarkins rarkins enabled auto-merge May 28, 2024 05:21
auto-merge was automatically disabled May 28, 2024 05:45

Head branch was pushed to by a user without write access

@george-wilson-rea
Copy link
Contributor Author

Sorry for the churn; I needed to run prettier.

@rarkins rarkins enabled auto-merge May 28, 2024 05:54
@rarkins rarkins added this pull request to the merge queue May 28, 2024
Merged via the queue into renovatebot:main with commit 9c11e43 May 28, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.380.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@george-wilson-rea george-wilson-rea deleted the scala3-dependency-versions branch June 3, 2024 05:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Scala 3 dependency resolution in sbt manager
3 participants