-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pipenv): Rewrite test mocks #29734
Merged
rarkins
merged 14 commits into
renovatebot:main
from
zharinov:refactor/pipenv-artifact-tests
Jul 2, 2024
Merged
test(pipenv): Rewrite test mocks #29734
rarkins
merged 14 commits into
renovatebot:main
from
zharinov:refactor/pipenv-artifact-tests
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 looks like a step back from our tooling best practices. we explicitly want to not mock fs-extra to allow partial real fa reads.
|
viceice
reviewed
Jul 1, 2024
rarkins
previously approved these changes
Jul 1, 2024
@zharinov failures on windows:
|
rarkins
previously approved these changes
Jul 1, 2024
rarkins
approved these changes
Jul 2, 2024
🎉 This issue has been resolved in version 37.421.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bryannaegele
pushed a commit
to bryannaegele/renovate
that referenced
this pull request
Jul 8, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prepare the codebase for usage of external
detect-tools
package: mockfs-extra
instead of internal fs utils.This should make our extracted code to act as drop-in replacement with no other changes required. The alternative could be mocking of the
detect-tools
itself, but in this case we are losing test coverage (while pretending we have it).Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: