Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tool detection to renovatebot/detect-tools #29000

Open
rarkins opened this issue May 11, 2024 · 4 comments · Fixed by #29787
Open

Move tool detection to renovatebot/detect-tools #29000

rarkins opened this issue May 11, 2024 · 4 comments · Fixed by #29787
Assignees
@zharinov
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2024

Describe the proposed change(s).

We should move tool detection to a separate repo/module so that it can be shared outside Renovate, particularly with some Containerbase tooling we are building.

Start with Poetry and Pipenv.

Example from: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/pipenv/artifacts.ts

Instead of a getPythonConstraint() function where we pass content to the function, we should instead call our new external library and pass it a fully qualified path/directory.
@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code labels May 11, 2024
This was referenced Jun 18, 2024
Merged
Merged
@rarkins rarkins added the status:in-progress Someone is working on implementation label Jul 1, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice reopened this Aug 16, 2024
@viceice
Copy link
Member

viceice commented Aug 16, 2024

we only fixed a single manager

@sspans-sbp

This comment has been minimized.

Sign in to view
@viceice

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zharinov zharinov

Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pipenv): Use @renovatebot/detect-tools for constraints detection zharinov/renovate
5 participants
@zharinov @viceice @rarkins @renovate-release @sspans-sbp