-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): add bun-version manager #29998
base: main
Are you sure you want to change the base?
feat(manager): add bun-version manager #29998
Conversation
|
||
export const defaultConfig = { | ||
fileMatch: ['(^|/)\\.bun-version$'], | ||
versioning: semverVersioning.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versioning: semverVersioning.id, |
use the default version of the datasource
}); | ||
|
||
it('handles no newline at the end', () => { | ||
const res = extractPackageFile('1.1.15'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the standard really require a new line at the end?
depName: 'Bun', | ||
packageName: 'oven-sh/bun', | ||
currentValue: content.trim(), | ||
datasource: GithubReleasesDatasource.id, | ||
versioning: semverVersioning.id, | ||
extractVersion: '^bun-v(?<version>\\S+)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depName: 'Bun', | |
packageName: 'oven-sh/bun', | |
currentValue: content.trim(), | |
datasource: GithubReleasesDatasource.id, | |
versioning: semverVersioning.id, | |
extractVersion: '^bun-v(?<version>\\S+)', | |
depName: 'Bun', | |
packageName: 'bun', | |
currentValue: content.trim(), | |
datasource: NpmDatasource.id, |
Let's use the bun
npm package that way we get more metadata and no extractVersion
is necessary. Further also this prevent failures downstream in case there is a release but not yet a NPM package.
https://www.npmjs.com/package/bun
@@ -0,0 +1,42 @@ | |||
import type { Category } from '../../../constants'; | |||
import { GithubReleasesDatasource } from '../../datasource/github-releases'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { GithubReleasesDatasource } from '../../datasource/github-releases'; | |
import { NpmDatasource } from '../../datasource/npm'; |
Changes
This PR adds a new manager :
bun-version
Context
The
bun
manager was already quite complex, so I created a new one. However, if needed, I can try to merge my modifications in it.Closes #29941
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: