feat(manager): add bun-version manager #29998
Open
+108
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
Jul 3, 2024
secustor
requested changes
Jul 7, 2024
secustor
requested changes
Aug 20, 2024
|
|
||
| export const defaultConfig = { | ||
| fileMatch: ['(^|/)\\.bun-version$'], | ||
| versioning: semverVersioning.id, |
There was a problem hiding this comment.
Suggested change
| versioning: semverVersioning.id, |
use the default version of the datasource
| }); | ||
|
|
||
| it('handles no newline at the end', () => { | ||
| const res = extractPackageFile('1.1.15'); |
There was a problem hiding this comment.
Does the standard really require a new line at the end?
Comment on lines
+30
to
+35
| depName: 'Bun', | ||
| packageName: 'oven-sh/bun', | ||
| currentValue: content.trim(), | ||
| datasource: GithubReleasesDatasource.id, | ||
| versioning: semverVersioning.id, | ||
| extractVersion: '^bun-v(?<version>\\S+)', |
There was a problem hiding this comment.
Suggested change
| depName: 'Bun', | |
| packageName: 'oven-sh/bun', | |
| currentValue: content.trim(), | |
| datasource: GithubReleasesDatasource.id, | |
| versioning: semverVersioning.id, | |
| extractVersion: '^bun-v(?<version>\\S+)', | |
| depName: 'Bun', | |
| packageName: 'bun', | |
| currentValue: content.trim(), | |
| datasource: NpmDatasource.id, |
Let's use the bun npm package that way we get more metadata and no extractVersion is necessary. Further also this prevent failures downstream in case there is a release but not yet a NPM package.
https://www.npmjs.com/package/bun
| @@ -0,0 +1,42 @@ | |||
| import type { Category } from '../../../constants'; | |||
| import { GithubReleasesDatasource } from '../../datasource/github-releases'; | |||
There was a problem hiding this comment.
Suggested change
| import { GithubReleasesDatasource } from '../../datasource/github-releases'; | |
| import { NpmDatasource } from '../../datasource/npm'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new manager :
bun-versionContext
The
bunmanager was already quite complex, so I created a new one. However, if needed, I can try to merge my modifications in it.Closes #29941
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: