Support Yarn v2 #5230

rarkins · 2020-01-27T08:00:12Z

What would you like Renovate to be able to do?

Support updating repositories which use Yarn v2

Describe the solution you'd like

It should require no custom config and "just work".

Describe alternatives you've considered

Staying on Yarn v1 until Renovate supports v2
Disabling Renovate for Yarn updating
Letting Renovate update Yarn, and manually fixing each PR if necessary

Additional context

https://dev.to/arcanis/introducing-yarn-2-4eh1 by @arcanis

rarkins · 2020-01-27T08:05:48Z

@viceice have you been able to gather the list of things we need to do differently?

rarkins · 2020-01-27T11:47:30Z

Migration guide: https://yarnpkg.com/advanced/migration

Things I've noted:

No longer looking at .yarnrc or .npmrc. This is particularly important when Renovate users need to authenticate with registries
"The yarn-offline-mirror has been removed, since the offline mirror has been merged with the cache as part of the Zero-Install effort. Just commit the Yarn cache and you're ready to go.". I guess Renovate now needs to detect/update the Yarn cache where applicable.
Currently our renovate/yarn container build is broken because the website bash-based install doesn't support pre-releases

christophehurpeau · 2020-03-04T16:01:10Z

Hello, do you plan to work on this ? Is there something I can do to help ?

rarkins · 2020-03-04T16:14:47Z

If you can create one or more repos to test against plus identify any shortcomings compared to today then that would help. I’m not using v2 yet so don’t have personal experience to reflect on

christophehurpeau · 2020-03-04T17:10:47Z

I have this repo: https://github.com/christophehurpeau/pob-eslint-config

rarkins · 2020-03-04T17:55:58Z

And how are Renovate PRs wrong today? What’s missing?

christophehurpeau · 2020-03-05T09:20:33Z

There's an error: christophehurpeau/eslint-config-pob#116 (comment)
I look at the log in app.renovatebot.com/dashboard and the real error seems to be: Error: Unsupported option name (\"--ignore-scripts\")

(branch="renovate/pob-dependencies")
DEBUG: lock file error(branch="renovate/pob-dependencies")
{
  "cmd": "npm i -g -C ~/.npm/lerna@3.20.2 lerna@3.20.2 && yarn install --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879 && ~/.npm/lerna@3.20.2/bin/lerna bootstrap --no-ci -- --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879",
  "err": {
    "killed": false,
    "code": 1,
    "signal": null,
    "cmd": "npm i -g -C ~/.npm/lerna@3.20.2 lerna@3.20.2 && yarn install --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879 && ~/.npm/lerna@3.20.2/bin/lerna bootstrap --no-ci -- --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879",
    "stdout": "/home/ubuntu/.npm/lerna@3.20.2/bin/lerna -> /home/ubuntu/.npm/lerna@3.20.2/lib/node_modules/lerna/cli.js\n+ lerna@3.20.2\nupdated 1 package in 35.127s\nUnknown Syntax Error: Unsupported option name (\"--ignore-scripts\").\n\n$ yarn install [--json] [--immutable] [--immutable-cache] [--check-cache] [--inline-builds] [--cache-folder #0]\n",
    "stderr": "npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142\n",
    "message": "Command failed: npm i -g -C ~/.npm/lerna@3.20.2 lerna@3.20.2 && yarn install --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879 && ~/.npm/lerna@3.20.2/bin/lerna bootstrap --no-ci -- --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879\nnpm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142\n",
    "stack": "Error: Command failed: npm i -g -C ~/.npm/lerna@3.20.2 lerna@3.20.2 && yarn install --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879 && ~/.npm/lerna@3.20.2/bin/lerna bootstrap --no-ci -- --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879\nnpm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142\n\n    at ChildProcess.exithandler (child_process.js:295:12)\n    at ChildProcess.emit (events.js:210:5)\n    at ChildProcess.EventEmitter.emit (domain.js:476:20)\n    at maybeClose (internal/child_process.js:1021:16)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)"
  },
  "type": "lerna",
  "lernaClient": "yarn"
}

rarkins · 2020-03-05T09:41:48Z

I'm not sure that the app is using Yarn v2 already, but in that case that error message is extra concerning

arcanis · 2020-03-05T09:50:29Z

All such settings are now expected to be kept within the yarnrc or the environment, so that they affect all commands and not only the one running now. In this case you'd replace --ignore-scripts with YARN_ENABLE_SCRIPTS=0 in the env.

arcanis · 2020-03-05T09:51:34Z

(Note that the engine and platform checks haven't been implemented yet but will generate warnings, not errors, so you won't need options or settings)

christophehurpeau · 2020-03-06T10:36:41Z

so the problem is on this line:

renovate/lib/manager/npm/post-update/yarn.ts

Line 91 in 92722fc

cmdExtras += ' --ignore-scripts';

? does YARN_ENABLE_SCRIPTS=0 is also supported in yarn 1 ?

arcanis · 2020-03-06T10:50:40Z

As far as I can tell, yep!

does YARN_ENABLE_SCRIPTS=0 is also supported in yarn 1 ?

No, it's 2.x only (it can be semver-checked on yarn --version).

christophehurpeau · 2020-04-13T12:59:25Z

So I tried the latest release and there is another issue: the yarn.lock is not updated.

There is this warning in the logs:

DEBUG: Warning: Exception parsing yarn.lock
{
  "filePath": "yarn.lock",
  "err": {
    "message": "Unknown token: { line: 3, col: 2, type: 'INVALID', value: undefined } 3:2 in lockfile",
    "stack": "SyntaxError: Unknown token: { line: 3, col: 2, type: 'INVALID', value: undefined } 3:2 in lockfile\n    at Parser.unexpected (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:5064:11)\n    at Parser.parse (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:5193:14)\n    at parse (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:5262:17)\n    at Object.module.exports.exports.default (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:4835:96)\n    at Object.getYarnLock (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/yarn.js:9:43)\n    at runMicrotasks ()\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)\n    at async Object.getLockedVersions (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/locked-versions.js:16:43)\n    at async postExtract (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/index.js:346:5)\n    at async Object.extractAllPackageFiles (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/index.js:366:5)\n    at async Object.extractAllDependencies (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/extract/index.js:28:28)\n    at async Object.extractAndUpdate (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/process/extract-update.js:12:26)\n    at async Object.renovateRepository (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/index.js:34:61)\n    at async renovateRepository (/home/ubuntu/renovateapp/app/worker/index.js:520:26)\n    at async /home/ubuntu/renovateapp/app/worker/index.js:742:5"
  }
}

Code: https://github.com/renovatebot/renovate/blob/master/lib/manager/npm/extract/yarn.ts#L1

I think we should use @yarnpkg/parsers instead which supports both lockfile versions, but I don't know how I could adapt that line:
https://github.com/renovatebot/renovate/blob/master/lib/manager/npm/extract/locked-versions.ts#L21-L22

adriencohen · 2020-06-11T17:04:47Z

While waiting for the full support is there any special config/patch which could make renovate work with yarn berry even if it breaks yarn 1 support ?

rarkins · 2020-06-11T18:12:06Z

No, but after some recent refactoring I think we’re in a much better position to implement this. So you have any example repo you can contribute towards testing?

JamieMagee · 2020-06-11T19:32:52Z

@adriencohen We're waiting on yarnpkg/berry#1278 before we can fully support yarn v2. It's got a lot of attention right now, so I expect it won't be too much longer to wait.

adriencohen · 2020-06-11T21:33:36Z

Thank you for the update, unfortunately I can't share with you my repo but it's a yarn 2 monorepo and if you need to test some stuff i'll try on it and report to you.
Right now I have the issue mentionned above about the unknown parameters of yarn install

itaylor · 2020-07-10T07:11:03Z

@rarkins, you'd asked for an example repo that exhibits the problems with yarn 2 repos.

This isn't a pure example repo, but it's a public repo and has a PR here from renovate bot that fails:
itaylor/bucket-ts#2

The likely relevant parts in the logs in the renovate console are:

DEBUG: Detecting Lerna and Yarn Workspaces
DEBUG: Found monorepo packages with base path "."(packageFile="package.json")
{
  "yarnWorkspacesPackages": [
    "packages/*",
    "tests"
  ]
}
DEBUG: Finding locked versions
DEBUG: Warning: Exception parsing yarn.lock
{
  "filePath": "yarn.lock",
  "err": {
    "message": "Unknown token: { line: 3, col: 2, type: 'INVALID', value: undefined } 3:2 in lockfile",
    "stack": "SyntaxError: Unknown token: { line: 3, col: 2, type: 'INVALID', value: undefined } 3:2 in lockfile\n    at Parser.unexpected (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:5064:11)\n    at Parser.parse (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:5193:14)\n    at parse (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:5262:17)\n    at Object.exports.default (/home/ubuntu/renovateapp/node_modules/@yarnpkg/lockfile/index.js:4835:96)\n    at Object.getYarnLock (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/yarn.js:10:43)\n    at async Object.getLockedVersions (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/locked-versions.js:17:43)\n    at async postExtract (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/index.js:368:5)\n    at async Object.extractAllPackageFiles (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/npm/extract/index.js:389:5)\n    at async Object.extractAllPackageFiles (/home/ubuntu/renovateapp/node_modules/renovate/dist/manager/index.js:37:21)\n    at async Object.getManagerPackageFiles (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/extract/manager-files.js:27:33)\n    at async /home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/extract/index.js:40:30\n    at async Promise.all (index 1)\n    at async Object.extractAllDependencies (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/extract/index.js:39:28)\n    at async Object.extract (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/process/extract-update.js:59:24)\n    at async Object.extractDependencies (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/process/index.js:73:30)\n    at async Object.renovateRepository (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/index.js:39:56)\n    at async renovateRepository (/home/ubuntu/renovateapp/app/worker/index.js:310:26)\n    at async /home/ubuntu/renovateapp/app/worker/index.js:512:5"
  }
}

And

DEBUG: Executing command(branch="renovate/pin-dependencies")
{
  "command": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\""
}
DEBUG: lock file error(branch="renovate/pin-dependencies")
{
  "err": {
    "killed": false,
    "code": 1,
    "signal": null,
    "cmd": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"",
    "stdout": "/home/ubuntu/.npm-global/bin/yarn -> /home/ubuntu/.npm-global/lib/node_modules/yarn/bin/yarn.js\n/home/ubuntu/.npm-global/bin/yarnpkg -> /home/ubuntu/.npm-global/lib/node_modules/yarn/bin/yarn.js\n+ yarn@1.22.4\nadded 1 package in 1.772s\nUnknown Syntax Error: Unsupported option name (\"--ignore-platform\").\n\n$ yarn install [--json] [--immutable] [--immutable-cache] [--check-cache] [--inline-builds]\n",
    "stderr": "",
    "message": "Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\n",
    "stack": "Error: Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\n\n    at ChildProcess.exithandler (child_process.js:303:12)\n    at ChildProcess.emit (events.js:311:20)\n    at ChildProcess.EventEmitter.emit (domain.js:482:12)\n    at maybeClose (internal/child_process.js:1021:16)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)"
  },
  "type": "yarn"
}
DEBUG: No updated lock files in branch(branch="renovate/pin-dependencies")

Hopefully this is helpful

MiroslavPetrik · 2020-07-20T12:04:18Z

I'm having this issue as well. Is there some estimate when this will be supported? I don't consider myself early adopter, would be nice to have this running!

itaylor · 2020-08-25T15:47:30Z

This is marked as Done, but when I run it with the latest release in what I believe is a basic yarn 2 configuration, I'm still getting errors:

Specifically the yarn.lock files fail to be updated because renovate runs yarn with options that yarn v2 doesn't support:

DEBUG: Executing command(branch="renovate/typescript-4.x")
{
  "command": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\""
}
DEBUG: lock file error(branch="renovate/typescript-4.x")
{
  "err": {
    "killed": false,
    "code": 1,
    "signal": null,
    "cmd": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"",
    "stdout": "/home/ubuntu/.npm-global/bin/yarn -> /home/ubuntu/.npm-global/lib/node_modules/yarn/bin/yarn.js\n/home/ubuntu/.npm-global/bin/yarnpkg -> /home/ubuntu/.npm-global/lib/node_modules/yarn/bin/yarn.js\n+ yarn@1.22.4\nadded 1 package in 0.969s\nUnknown Syntax Error: Unsupported option name (\"--ignore-platform\").\n\n$ yarn install [--json] [--immutable] [--immutable-cache] [--check-cache] [--inline-builds]\n",
    "stderr": "",
    "message": "Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\n",
    "stack": "Error: Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/itaylor/bucket-ts\":\"/mnt/renovate/gh/itaylor/bucket-ts\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/itaylor/bucket-ts\" renovate/node bash -l -c \"npm i -g yarn && sed -i 's/ steps,/ steps.slice(0,1),/' /home/ubuntu/.npm-global/lib/node_modules/yarn/lib/cli.js && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\n\n    at ChildProcess.exithandler (child_process.js:303:12)\n    at ChildProcess.emit (events.js:311:20)\n    at ChildProcess.EventEmitter.emit (domain.js:482:12)\n    at maybeClose (internal/child_process.js:1021:16)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)"
  },
  "type": "yarn"
}
DEBUG: No updated lock files in branch(branch="renovate/typescript-4.x")
DEBUG: Branch timestamp: 2020-08-20T15:59:24.994Z(branch="renovate/typescript-4.x")

This can be seen in a public repository here: itaylor/bucket-ts#7 (comment)

I think this was also noted by @christophehurpeau in #6045 (comment).
Is there some way to work around it?

rarkins · 2020-08-25T15:51:32Z

Reopening. Should hopefully be quick to fix.

viceice · 2020-08-25T16:00:17Z

It would be awesome if anybody can send us a pr with the required argument changes for yarn v2 🙃

jalovatt · 2020-08-25T16:42:30Z

This was partly covered earlier in the thread: #5230 (comment)

ignore-scripts is enableScripts: false in .yarnrc now, or an env variable from the command line
ignore-platform is just... gone. I can't find any documentation on what it was doing beyond "Ignores platform checking", no mentions of it in the v2 repo, and only a few instances on Google of people using it. There aren't any config options in the .yarnrc docs for v2 matching "platform", at any rate.

ignore-engines tosses up a deprecation notice:

YN0050: The --ignore-engines option is deprecated; engine checking isn't a core feature anymore

ylemkimon · 2020-09-07T17:38:15Z

Few notes:

.yarnrc.yml: Yarn 2 has changed the name of the configuration file from .yarnrc to .yarnrc.yml and allows configuring its name via an environment variable
Zero-installs: .pnp.* and .yarn/cache (offline cache, configurable via Yarnrc) are updated and need to be committed when dependencies are updated (feat(npm): support Yarn 2 offline cache and zero-installs #7220)
Yarn 2 allows configuring the name of lockfile

itaylor · 2020-09-08T17:57:47Z

With the current release of renovate 23.19.1, I'm able to get yarn 2 support working! 🎉
However, it still doesn't work correctly out of the box, without using some undocumented configuration.

In order to make it work, I had to add to my renovate.json file:

  "compatibility": {
    "yarn": "2.x"
  }

In the docs, yarn is not documented as being one of the options for "compatibility" (see https://docs.renovatebot.com/configuration-options/#compatibility ). In order to figure out that's what it needs, I had to go read the renovate code.

It would be much nicer if renovate could query yarn to determine what yarn version is used, instead of making me declare which version I'm using. I understand that this is complicated by the fact that the yarn global executable is a different version than the yarn executable that is checked into the project in the .yarn folder.

ylemkimon · 2020-09-08T23:53:28Z

@itaylor Renovate is able to detect the Yarn version from its lockfile:

renovate/lib/manager/npm/extract/locked-versions.ts

Lines 15 to 27 in 605346f

    
           logger.trace('Found yarnLock'); 
        
           if (!lockFileCache[yarnLock]) { 
        
             logger.trace('Retrieving/parsing ' + yarnLock); 
        
             const { lockedVersions, cacheVersion, isYarn1 } = await getYarnLock( 
        
               yarnLock 
        
             ); 
        
             lockFileCache[yarnLock] = lockedVersions; 
        
             if (!isYarn1) { 
        
               if (cacheVersion >= 6) { 
        
                 // https://github.com/yarnpkg/berry/commit/f753790380cbda5b55d028ea84b199445129f9ba 
        
                 packageFile.compatibility.yarn = '>= 2.2.0'; 
        
               } else { 
        
                 packageFile.compatibility.yarn = '>= 2.0.0';

itaylor · 2020-09-09T02:52:49Z

@ylemkimon maybe it should use that when it goes to compute isYarn1 in post-update/yarn.ts

renovate/lib/manager/npm/post-update/yarn.ts

Lines 50 to 55 in fbd0fdd

    
           const yarnCompatibility = config.compatibility?.yarn; 
        
           const minYarnVersion = 
        
             validRange(yarnCompatibility) && minVersion(yarnCompatibility); 
        
           const isYarn1 = !minYarnVersion || minYarnVersion.major === 1; 
        
           const isYarnDedupeAvailable = 
        
             minYarnVersion && gte(minYarnVersion, '2.2.0');

As the code works right now, the lockfile doesn't get regenerated and the renovate run ends with an error on yarn 2 unless you've specified a compatibility setting in the config that tells it to use yarn 2.

JamieMagee · 2020-09-09T07:26:12Z

Thanks for the list and the PRs @ylemkimon.

I'm currently looking at the yarnrc/.yarnrc.yml issue.

ylemkimon · 2020-09-17T13:01:29Z

@JamieMagee Could you check whether it still needs configuring compatibility manually with the latest version (>=23.29.1)?

JamieMagee · 2020-09-19T11:36:06Z

@ylemkimon I'm still seeing the same issue when running the latest Renovate 23.31.2 against JamieMagee/bookshelf. Investigating now.

JamieMagee · 2020-09-19T12:29:18Z

Okay, I've fixed it. The issue is that the compatibility was only being set for the first package.json that was detected, due to how this if/else statement was constructed.

renovate/lib/manager/npm/extract/locked-versions.ts

Lines 16 to 30 in 1b99f4f

    
           if (!lockFileCache[yarnLock]) { 
        
             logger.trace('Retrieving/parsing ' + yarnLock); 
        
             const { lockedVersions, cacheVersion, isYarn1 } = await getYarnLock( 
        
               yarnLock 
        
             ); 
        
             lockFileCache[yarnLock] = lockedVersions; 
        
             if (!isYarn1) { 
        
               if (cacheVersion >= 6) { 
        
                 // https://github.com/yarnpkg/berry/commit/f753790380cbda5b55d028ea84b199445129f9ba 
        
                 packageFile.compatibility.yarn = '>= 2.2.0'; 
        
               } else { 
        
                 packageFile.compatibility.yarn = '>= 2.0.0'; 
        
               } 
        
             } 
        
           }

isYarn1, and the following logic, was only being executed if the lockfile was not found in the cache.

Here's a sample PR I just generated JamieMagee/bookshelf#15. I need to look at tests + coverage, but I will send out a PR shortly.

JamieMagee · 2020-09-19T14:01:49Z

Opened PR at #7330

JamieMagee · 2020-09-19T16:18:35Z

@ylemkimon My fix is in version 23.31.3. Can you give it a go and see if it works for you?

ylemkimon · 2020-09-21T10:20:49Z

@JamieMagee Actually, my installation worked before. Probably the issue was with Yarn workspaces (monorepo) because mine was
a single package. I've created a demo monorepo and it seems to work! Thank you.

JamieMagee · 2020-09-21T13:23:30Z

@ylemkimon Excellent! I fixed a bug no-one complained about yet 😅

I think that the basic scenarios for Yarn v2 should now be covered without any additional Renovate conviguration. However, the issues you detailed above are still an issue. Would you agree?

brummelte · 2020-10-19T13:43:59Z

Yes #7220 is still an issue.

Otherwise a pipeline that uses yarn install --immutable --immutable-cache will fail. And it would require a manual commit with the new dependencies added.

JamieMagee · 2020-10-19T19:04:26Z

@brummelte Looks like #7220 was approved waiting to be merged. I've merged in the latest changes from master, and will merge if all tests pass.

brummelte · 2020-10-28T10:02:42Z

It seems to work well with yarn 2 in my case.

I've only noticed a minor inconvenience (#7584).

rarkins · 2021-01-06T07:14:17Z

Let's close this general issue then. Thanks everyone for the help

rarkins added type:feature Feature (new functionality) needs-requirements priority-2-high Bugs impacting wide number of users or very important features manager:npm package.json files (npm/yarn/pnpm) labels Jan 27, 2020

rarkins assigned viceice Jan 27, 2020

christophehurpeau mentioned this issue Mar 6, 2020

feat: yarn 2 #5657

Merged

christophehurpeau mentioned this issue Apr 24, 2020

feat: yarn2 lockfile support #6045

Merged

christophehurpeau mentioned this issue May 2, 2020

Yarn 2 christophehurpeau/pob#554

Closed

dannycoates mentioned this issue May 26, 2020

chore(deps): update some dependencies mozilla/fxa#5441

Merged

rarkins removed the needs-requirements label Jun 18, 2020

davissorenson mentioned this issue Jul 4, 2020

After upgrading to Yarn 2.0.0-rc.36 & PnP, Renovate no longer updates yarn.lock, complains about artifact update problem renovatebot/app-support#59

Closed

rarkins reopened this Aug 25, 2020

kidonng mentioned this issue Sep 1, 2020

feat(npm): Update Yarn install arguments #7156

Merged

christophehurpeau mentioned this issue Sep 4, 2020

fix: don't try to install yarn 2 from npm #7183

Merged

ylemkimon mentioned this issue Sep 7, 2020

fix(npm): yarnDedupeHighest for Yarn 2 #7200

Merged

JamieMagee mentioned this issue Sep 9, 2020

fix(yarn): yarn v2 yarnrc support #7235

Closed

This was referenced Sep 13, 2020

fix(npm): use compatibility from the packageFile in generateLockFile #7270

Closed

Incorrect compatibility config when multiple package files exist #7285

Closed

rdicroce mentioned this issue Sep 22, 2020

Respect .yarnrc.yml registry config #7351

Closed

rarkins closed this as completed Jan 6, 2021

github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2021

Support Yarn v2 #5230

Support Yarn v2 #5230

Comments

rarkins commented Jan 27, 2020

rarkins commented Jan 27, 2020

rarkins commented Jan 27, 2020

christophehurpeau commented Mar 4, 2020

rarkins commented Mar 4, 2020

christophehurpeau commented Mar 4, 2020

rarkins commented Mar 4, 2020

christophehurpeau commented Mar 5, 2020

rarkins commented Mar 5, 2020

arcanis commented Mar 5, 2020

arcanis commented Mar 5, 2020

christophehurpeau commented Mar 6, 2020

arcanis commented Mar 6, 2020

christophehurpeau commented Apr 13, 2020 • edited Loading

adriencohen commented Jun 11, 2020

rarkins commented Jun 11, 2020

JamieMagee commented Jun 11, 2020

adriencohen commented Jun 11, 2020

itaylor commented Jul 10, 2020

MiroslavPetrik commented Jul 20, 2020

itaylor commented Aug 25, 2020 • edited Loading

rarkins commented Aug 25, 2020

viceice commented Aug 25, 2020

jalovatt commented Aug 25, 2020

ylemkimon commented Sep 7, 2020 • edited Loading

itaylor commented Sep 8, 2020

ylemkimon commented Sep 8, 2020

itaylor commented Sep 9, 2020 • edited Loading

JamieMagee commented Sep 9, 2020

ylemkimon commented Sep 17, 2020 • edited Loading

JamieMagee commented Sep 19, 2020

JamieMagee commented Sep 19, 2020

JamieMagee commented Sep 19, 2020

JamieMagee commented Sep 19, 2020

ylemkimon commented Sep 21, 2020

JamieMagee commented Sep 21, 2020

brummelte commented Oct 19, 2020

JamieMagee commented Oct 19, 2020

brummelte commented Oct 28, 2020

rarkins commented Jan 6, 2021

christophehurpeau commented Apr 13, 2020 •

edited

Loading

itaylor commented Aug 25, 2020 •

edited

Loading

ylemkimon commented Sep 7, 2020 •

edited

Loading

itaylor commented Sep 9, 2020 •

edited

Loading

ylemkimon commented Sep 17, 2020 •

edited

Loading