test: fix memory leak #10162
Merged
test: fix memory leak #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
May 26, 2021
| jest.mock('../lib/platform', () => ({ | ||
| platform: jest.createMockFromModule('../lib/platform/github'), | ||
| initPlatform: jest.fn(), | ||
| getPlatformList: jest.fn(), | ||
| })); | ||
| jest.mock('../lib/logger'); | ||
|
|
||
| beforeAll(() => { | ||
| nock.disableNetConnect(); |
There was a problem hiding this comment.
I guess the idea of this was to block all external connections?
There was a problem hiding this comment.
yes, but it caused the memory issues, see https://github.com/nock/nock#memory-issues-with-jest
rarkins
approved these changes
May 26, 2021
|
🎉 This PR is included in version 25.31.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fix a huge memory leak in jest. It seems global
nockusage caused it. Also refactord a litle bit to reduce more leaks.This fix reduced the node heap usage with 8 worker down from ~700MB to ~200MB. 🎉
Also test time went down from ~90s to ~80s.
Context:
Extracted from #10160, ref #10159
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: