Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(local development): add refactor PR test note #13335

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

HonkingGoose
Copy link
Collaborator

Changes:

  • Add note that explains that refactoring PRs should not change tests (ideally)

Context:

Inspired by the comment from the head maintainer (#13328 (comment)):

For future reference, refactor PRs should ideally not change or remove tests (adding tests is OK). This PR as it is demands that the reviewer do a lot of manual testing, which increases the chance that it sits unreviewed.

Not closing any issue with this PR.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 64e5c70 into renovatebot:main Jan 3, 2022
@HonkingGoose HonkingGoose deleted the patch-1 branch January 3, 2022 10:26
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zanitete pushed a commit to nagra-insight/renovate that referenced this pull request Jan 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants