Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pep440): ensure strict null check #13409

Merged
merged 21 commits into from
Jan 13, 2022
Merged

refactor(pep440): ensure strict null check #13409

merged 21 commits into from
Jan 13, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jan 6, 2022 •
edited
Loading

Changes:

  • Fix strict null errors.

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins reviewed Jan 6, 2022
View reviewed changes
.ls-lint.yml Outdated Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

Blocked by renovate/pep440(#113)

viceice
viceice reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by renovatebot/pep440#122

@viceice viceice marked this pull request as draft January 11, 2022 13:16
@viceice
Copy link
Member

viceice commented Jan 11, 2022

You can continue on this pr, you need to use this package now https://www.npmjs.com/package/@renovatebot/pep440

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review January 12, 2022 04:07
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jan 12, 2022 •
edited
Loading

@viceice @rarkins Ready for review and merge.🟩

viceice
viceice reviewed Jan 12, 2022
View reviewed changes
.ls-lint.yml Outdated Show resolved Hide resolved
lib/versioning/pep440/index.ts Outdated Show resolved Hide resolved
lib/versioning/pep440/index.ts Outdated Show resolved Hide resolved
lib/versioning/pep440/index.ts Outdated Show resolved Hide resolved
lib/versioning/pep440/index.ts Show resolved Hide resolved
lib/versioning/pep440/index.ts Outdated Show resolved Hide resolved
lib/versioning/pep440/range.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 4 commits January 13, 2022 13:58
viceice
viceice reviewed Jan 13, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small issues left

lib/versioning/pep440/index.ts Outdated Show resolved Hide resolved
lib/versioning/pep440/index.ts Outdated Show resolved Hide resolved
@viceice viceice merged commit 2459107 into renovatebot:main Jan 13, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice mentioned this pull request Jan 14, 2022
Closed
24 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
@RahulGautamSingh RahulGautamSingh deleted the refactor(pep440)/ensure-strict-null-check branch February 19, 2022 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulGautamSingh @viceice @renovate-release @rarkins