Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/pipenv): support binarySource=install #16828

Merged
merged 6 commits into from
Jul 28, 2022
Merged

feat(manager/pipenv): support binarySource=install #16828

merged 6 commits into from
Jul 28, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 28, 2022 •
edited
Loading

Changes

  • use sidecar for docker mode
  • support binarySource=install
  • requires sidecar v4.8.0+

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice mentioned this pull request Jul 28, 2022
Closed
20 tasks
@viceice viceice requested a review from rarkins July 28, 2022 09:15
@viceice
Copy link
Member Author

viceice commented Jul 28, 2022

@rarkins Will mark as ready when sidecar v4.8 is release, but can be reviewed now. Will also run some real tests

@viceice viceice marked this pull request as ready for review July 28, 2022 10:04
@viceice viceice enabled auto-merge (squash) July 28, 2022 16:11
@viceice viceice merged commit a3d1235 into main Jul 28, 2022
@viceice viceice deleted the feat/pipenv-buildpack branch July 28, 2022 17:17
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.133.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viceice @renovate-release @rarkins