-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/onboarding): support manual rebase/retry #17633
feat(core/onboarding): support manual rebase/retry #17633
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
d5d45cb
to
664f474
Compare
…etti/renovate into rebase-onboarding � Conflicts: � lib/modules/platform/pr-body.ts
Should we be worried about exceeding 60k characters here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MassageMarkdown for other platform that dont support html comments and checkboxes
azure/Bitbucket/bitbucket-server
and soon AWS
use sha256 to hash config
…etti/renovate into rebase-onboarding
623e0fa
to
f455072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think any of this can be broken up into smaller pieces? There's a lot of code being touched here
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
d658c49
to
7d387bc
Compare
9d6ba16
to
f0d21ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need extensive real repo testing
# Conflicts: # lib/workers/repository/onboarding/branch/index.spec.ts
…etti/renovate into rebase-onboarding
Ill run some e2e tests on GitHub and Bitbucket again, hopefully in the coming days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm 🤷♂️
# Conflicts: # lib/workers/repository/index.ts
e2e testing:GithubRunning with the Turning Running again without modifications to the branch -> no lookup, repo cache remains the same.
Commit to branch -> changes detected -> extraction + lookup performed -> cache updated
Running again -> no extraction or lookup
Manually updating the PR body by deleting the checkbox prompt -> PR is getting fixed
Turning it off by Bitbucketenabling the feature has no effect.
{"name":"renovate","hostname":"Gabriel-Dell5420","pid":18052,"level":10,"logContext":"FAH6g4QH_X-6ucWQ4Jcrh","repository":"gabriel-ladzaretti/onboarding","msg":"Platform 'bitbucket' does not support extended markdown","time":"2023-01-08T21:48:58.411Z","v":0}
|
🎉 This PR is included in version 34.99.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Based on the feature flag value -
Supported platforms -
Unsupported platforms will be unaffected by this change.
Changed logic -
Extraction -> lookup -> PR creation/update
flow will now be preformed only when one of the following condition is met:If non of the above is met, repo cache is left unchanged as well (
setBranchCache
is skipped as part ofworker/index
,cache.scan
is written as part of the extraction, therefore is skipped as well).Note that the rebase terminology in the context of onboarding is a bit misleading, as the actual action preformed by checking the checkbox is Updating the onboarding PR.
Design consideration -
bodyStruct
infrastructure is already widely usedisBranchModified
) soisBranchModified
cant be used to detect config changes as it will always be true once other than renovate[bot] have committed to the branchContext
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: